Bug 31387 - Cut unnecessary sed hacks for Vala bindings
Summary: Cut unnecessary sed hacks for Vala bindings
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-11-04 11:20 UTC by Travis Reitter
Modified: 2011-07-28 11:19 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Travis Reitter 2010-11-04 11:20:12 UTC
With the Vala switch-to-gir branch (which Evan is about to merge), we can cut out the calls to sed (to do some scrubbing for the final telepathy-glib.vapi).
Comment 1 Travis Reitter 2010-11-04 11:22:40 UTC
This trivial branch does the trick:

http://git.collabora.co.uk/?p=user/treitter/telepathy-glib.git;a=shortlog;h=refs/heads/fdo31387-cut-sed
Comment 2 Simon McVittie 2010-11-04 11:31:39 UTC
I don't want to merge this until there's a somewhat widely available Vala release that's been verified not to need it, at which point we should bump the required version in configure.ac.
Comment 3 Evan Nemerson 2010-11-08 03:43:15 UTC
I just merged the switch-to-gir branch, and 0.11.2 should be released sometime today. There is an issue remaining about the namespace being based on the c:identifier-prefixes instead of the namespace name (so the namespace in Vala is Tp instead of TelepathyGLib), but that can be solved with a metadata file.
Comment 4 Travis Reitter 2010-11-08 10:30:33 UTC
(In reply to comment #3)
> I just merged the switch-to-gir branch, and 0.11.2 should be released sometime
> today. There is an issue remaining about the namespace being based on the
> c:identifier-prefixes instead of the namespace name (so the namespace in Vala
> is Tp instead of TelepathyGLib), but that can be solved with a metadata file.

This has been fixed in bug #31473.
Comment 5 Travis Reitter 2011-07-28 11:19:36 UTC
I confirmed this still works and pushed it:

commit f882f8c5b8f38251c151ff4cd0463cf3cd8af3e1
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date:   Thu Nov 4 11:19:15 2010 -0700

    Cut unnecessary sed hacks for Vala bindings.
    
    Fixes fdo#31387.

 configure.ac     |    2 +-
 vala/Makefile.am |    8 --------
 2 files changed, 1 insertions(+), 9 deletions(-)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.