Bug 31595 - Insufficient check on zlib
Summary: Insufficient check on zlib
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/libfontenc (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Alan Coopersmith
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 8256 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-13 05:30 UTC by Cyril Brulebois
Modified: 2018-06-17 19:19 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch submitted to xorg-devel for review (981 bytes, patch)
2010-11-19 22:06 UTC, Alan Coopersmith
no flags Details | Splinter Review

Description Cyril Brulebois 2010-11-13 05:30:25 UTC
My build (in a quite minimal chroot) broke with:

  CC     encparse.lo
encparse.c:39:18: error: zlib.h: No such file or directory
encparse.c:40: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘FontFilePtr’
encparse.c:84: error: expected ‘)’ before ‘f’
encparse.c:98: error: expected ‘)’ before ‘f’
encparse.c:131: error: expected ‘)’ before ‘f’
encparse.c:153: error: expected ‘)’ before ‘f’
encparse.c:198: error: expected ‘)’ before ‘f’
encparse.c:464: error: expected ‘)’ before ‘f’
[…]


I'm not sure configure.ac contains the needed bits:

# zlib
AC_CHECK_LIB(z, gzclose)


Relevant bits of config.log:

configure:11773: checking for gzclose in -lz
configure:11798: gcc -o conftest -g -O2  -L/home/kibi/xorg-build/lib64  conftest.c -lz   >&5
/usr/bin/ld: cannot find -lz
collect2: ld returned 1 exit status
configure:11798: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "libfontenc"
| #define PACKAGE_TARNAME "libfontenc"
| #define PACKAGE_VERSION "1.1.0"
| #define PACKAGE_STRING "libfontenc 1.1.0"
| #define PACKAGE_BUGREPORT "https://bugs.freedesktop.org/enter_bug.cgi?product=xorg"
| #define PACKAGE_URL ""
| #define PACKAGE "libfontenc"
| #define VERSION "1.1.0"
| #define STDC_HEADERS 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_SYS_STAT_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_MEMORY_H 1
| #define HAVE_STRINGS_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_UNISTD_H 1
| #define PACKAGE_VERSION_MAJOR 1
| #define PACKAGE_VERSION_MINOR 1
| #define PACKAGE_VERSION_PATCHLEVEL 0
| #define HAVE_DLFCN_H 1
| #define LT_OBJDIR ".libs/"
| /* end confdefs.h.  */
|
| /* Override any GCC internal prototype to avoid an error.
|    Use char because int might match the return type of a GCC
|    builtin and then its argument prototype would still apply.  */
| #ifdef __cplusplus
| extern "C"
| #endif
| char gzclose ();
| int
| main ()
| {
| return gzclose ();
|   ;
|   return 0;
| }
configure:11807: result: no
Comment 1 Alan Coopersmith 2010-11-19 22:06:00 UTC
Created attachment 40428 [details] [review]
Patch submitted to xorg-devel for review
Comment 2 Alan Coopersmith 2010-11-21 18:45:32 UTC
That patch has now been reviewed and pushed to git master.
Comment 3 Jesse Adkins 2010-11-26 18:21:18 UTC
*** Bug 8256 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.