Bug 31742 - [ironlake] fbc (disabled through chicken bits) 1 W increase on bltk-office/player benchmark
Summary: [ironlake] fbc (disabled through chicken bits) 1 W increase on bltk-office/pl...
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium enhancement
Assignee: Ben Widawsky
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-18 17:23 UTC by Alex
Modified: 2017-07-24 23:06 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Alex 2010-11-18 17:23:12 UTC
open fbc on ironlake cause about 1 Watss power increase on bltk-office/player benchmark. It is linux kernel driver bug. The following patch can disable the fbc and recover power regression. 

> ---
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 80745f8..029af7a 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -150,7 +150,7 @@ static const struct intel_device_info intel_ironlake_d_info = {
>  
>  static const struct intel_device_info intel_ironlake_m_info = {
>  	.gen = 5, .is_mobile = 1,
> -	.need_gfx_hws = 1, .has_fbc = 1, .has_rc6 = 1, .has_hotplug = 1,
> +	.need_gfx_hws = 1, .has_fbc = 0, .has_rc6 = 1, .has_hotplug = 1,
>  	.has_bsd_ring = 1,
>  };
Comment 1 Chris Wilson 2010-11-19 00:40:55 UTC
As FBC is disabled on ILK, yes we shouldn't be including it in its capabilities. I am interested in just where the current logic is failing. As you say it is a regression, and the hardware has always been broken, what triggered the regression?
Comment 2 Alex 2010-11-19 00:45:31 UTC
bltk-office and bltk-player will trigger this. 
that use openoffice 3.0 and mplayer
Comment 3 Chris Wilson 2010-11-19 02:07:29 UTC
I applied the patch to -fixes, but I'm leaving this bug open for the time being to see if there is anything else to fix in our FBC code paths.
Comment 4 Ben Widawsky 2011-01-21 16:31:00 UTC
I retested this using -fixes
4efe070896e1f7373c98a13713e659d1f5dee52a
drm/i915: make the blitter report buffer modifications to the FBC unit

           has_fbc = 0has_fbc = 1
----------------------
idle min          16.3       15.2
idle max          17.6       16.3
idle avg         16.94      15.67
office min        14.4       15.1
office max        23.9         28
office avg       15.57      17.33
Comment 5 Ben Widawsky 2011-05-28 15:27:02 UTC
FBC is turned off for relevant ILK platforms.
Comment 6 Florian Mickler 2011-06-30 03:17:30 UTC
A patch referencing this bug report has been merged in Linux v3.0-rc1:

commit c1a9f047638b27e481d097910604316b8a0d132b
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu May 5 15:24:21 2011 -0700

    drm/i915: add fbc enable flag, but disable by default
Comment 7 Florian Mickler 2011-08-08 01:51:33 UTC
A patch referencing this bug report has been merged in Linux v3.1-rc1:

commit 9ce9d0695d15da23ffe817516ba5d0b58caf8d05
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Fri Jul 8 12:22:40 2011 +0100

    drm/i915: Set persistent-mode for ILK/SNB framebuffer compression


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.