Bug 31846 - Jabber require_tls parameter has been replaced with a more annoying parameter
Summary: Jabber require_tls parameter has been replaced with a more annoying parameter
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: 0.4
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
: 34577 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-22 15:19 UTC by Jonny Lamb
Modified: 2013-09-23 15:22 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Jonny Lamb 2010-11-22 15:19:15 UTC
The require_tls jabber parameter which was previously there and was just renamed to require-encryption for Telepathy is now gone and has been replaced by a "connection-security" string parameter with values "require_tls", "opportunistic_tls", and "old_ssl".

The parameter mangling code will need to get smarter to deal with not only renaming, but sorting out this problem too. Sigh.
Comment 1 Jonny Lamb 2010-11-22 15:28:35 UTC
Also, this breaks the haze test suite.
Comment 2 Jonny Lamb 2010-11-22 15:33:21 UTC
(Looks like this is broken since pidgin 2.7.4.)
Comment 3 Simon McVittie 2010-11-30 10:11:08 UTC
I like the Haze tests to pass. Here's a branch.
Comment 4 Jonny Lamb 2010-12-01 01:32:19 UTC
I think I'd personally prefer NULL instead of "UNUSED", but I guess "UNUSED" is more explicit and it is only static. Up to you.

Seems fine otherwise. Nicely done.
Comment 5 Simon McVittie 2010-12-01 02:36:09 UTC
Fixed in git for 0.5.0.

I'll leave this open, since I haven't fixed it for the 0.4 branch, and that branch is significantly different (it doesn't have Protocol).
Comment 6 Simon McVittie 2012-10-11 09:32:43 UTC
(In reply to comment #5)
> I'll leave this open, since I haven't fixed it for the 0.4 branch

0.6.x is the new stable branch (as of 6 months ago), so I no longer care about 0.4. Fixed in 0.5.0.
Comment 7 Simon McVittie 2013-09-23 15:22:00 UTC
*** Bug 34577 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.