Bug 31918 - TpAccount API for Account.I.Addressing
Summary: TpAccount API for Account.I.Addressing
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: 0.13
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-11-25 07:20 UTC by Simon McVittie
Modified: 2010-12-01 05:27 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2010-11-25 07:20:24 UTC 
Some slightly higher-level API for Addressing would be nice. Here's a branch.
Comment 1 Jonny Lamb 2010-11-29 05:00:01 UTC 
Just two things wrong:

 * You're not freeing the priv->uri_schemes GStrv.
 * You forgot to document tp_account_get_feature_quark_addressing.
Comment 2 Simon McVittie 2010-12-01 04:32:25 UTC 
(In reply to comment #1)
>  * You're not freeing the priv->uri_schemes GStrv.

Oops, fixed.

>  * You forgot to document tp_account_get_feature_quark_addressing.

That's deliberate, those functions appear in a <SUBSECTION Private> (the documented API for them is to use the macros). I could remove the unnecessary documentation for the two existing ones if you want?
Comment 3 Jonny Lamb 2010-12-01 05:23:29 UTC 
(In reply to comment #2)
> That's deliberate, those functions appear in a <SUBSECTION Private> (the
> documented API for them is to use the macros). I could remove the unnecessary
> documentation for the two existing ones if you want?

Meh, whatever. I saw the other two documented and so thought it was necessary.

gogogogogogogo
Comment 4 Simon McVittie 2010-12-01 05:27:13 UTC 
Thanks, fixed in git for 0.13.8. You might also be interested in Bug #32004.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.