Bug 31981 - Contacts both on Allow List and Block List: Not Removed
Summary: Contacts both on Allow List and Block List: Not Removed
Status: RESOLVED NOTABUG
Alias: None
Product: papyon
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium minor
Assignee: papyon-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-29 20:42 UTC by ancanus
Modified: 2010-11-29 22:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description ancanus 2010-11-29 20:42:05 UTC
Everytime I start emesene, I get a bunch of these pop up:

[15:39:45 WARNING papyon.protocol.notification] Contact is on both Allow and Block list; removing from Allow list (xxxxxxxx@hotmail.com)

It says that it removes them from the Allow list, but this message keeps appearing every time emesene starts, so I assume it is not really removing them from the Allow List.
Comment 1 Louis-Francis Ratté-Boulianne 2010-11-29 21:30:25 UTC
They are indeed not really removed, I'm mimicking official client behavior.

How things are working:

- You receive the contacts from your address book (web service)
- You receive contacts memberships (Allow, Block, Pending) (another web service)
- You connect to messenger server and send your contact list with memberships

So the Allow membership is only removed from the final contact list we sent to the Live Messenger server (that is sent each time you connect) but not from the Address Book (permanent storage for contacts).

Conclusion: that's a harmless warning and I still prefer not to screw up the address book.
Comment 2 Youness Alaoui 2010-11-29 22:57:38 UTC
aMSN actually removes the contact from the AL on the server, because a contact in AL+BL is clearly a corruption/inconsistent status. It is probably caused by a connection drop while blocking/unblocking a user, and I don't think it should keep the inconsistent state once it detects it.. if you show the user as blocked, then remove him from the AL on the server.. otherwise you might even get an error later on if the user says 'unblock' and you do 'add to AL' which returns 'contact already exists' then, hopefully you'd need to handle that error case... 
IMHO, it's better to just fix the error rather than ignoring it.
Agree? Disagree?


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.