Neither Wocky included in the telepathy-gabble 0.11.3, the git master submodule "wocky" of telepathy-gabble or the code from git://git.collabora.co.uk/git/wocky.git will build on my Fedora 14 system. I have openssl-devel 1.0.0b installed. These are the errors I get: Making all in wocky make[2]: Entering directory `/home/Jon/telepathy-gabble/lib/ext/wocky/wocky' make all-am make[3]: Entering directory `/home/Jon/telepathy-gabble/lib/ext/wocky/wocky' /bin/sh ../libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -Wall -Wextra -Wdeclaration-after-statement -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Wsign-compare -Wnested-externs -Wpointer-arith -Wformat-security -Winit-self -Wno-missing-field-initializers -Wno-unused-parameter -Werror -Wno-error=missing-field-initializers -Wno-error=unused-parameter -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -DG_LOG_DOMAIN=\"wocky\" -g -O2 -MT wocky-openssl.lo -MD -MP -MF .deps/wocky-openssl.Tpo -c -o wocky-openssl.lo wocky-openssl.c libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -Wall -Wextra -Wdeclaration-after-statement -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Wsign-compare -Wnested-externs -Wpointer-arith -Wformat-security -Winit-self -Wno-missing-field-initializers -Wno-unused-parameter -Werror -Wno-error=missing-field-initializers -Wno-error=unused-parameter -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -DG_LOG_DOMAIN=\"wocky\" -g -O2 -MT wocky-openssl.lo -MD -MP -MF .deps/wocky-openssl.Tpo -c wocky-openssl.c -fPIC -DPIC -o .libs/wocky-openssl.o cc1: warnings being treated as errors wocky-openssl.c: In function 'check_peer_name': wocky-openssl.c:902:22: error: assignment discards qualifiers from pointer target type wocky-openssl.c: In function 'set_ecdh_key': wocky-openssl.c:1662:3: error: 'EC_KEY' undeclared (first use in this function) wocky-openssl.c:1662:3: note: each undeclared identifier is reported only once for each function it appears in wocky-openssl.c:1662:11: error: 'ecdh' undeclared (first use in this function) wocky-openssl.c:1662:3: error: implicit declaration of function 'EC_KEY_new_by_curve_name' wocky-openssl.c:1662:3: error: nested extern declaration of 'EC_KEY_new_by_curve_name' wocky-openssl.c:1669:3: error: implicit declaration of function 'EC_KEY_free' wocky-openssl.c:1669:3: error: nested extern declaration of 'EC_KEY_free' wocky-openssl.c: In function 'wocky_tls_session_constructed': wocky-openssl.c:1680:23: error: assignment discards qualifiers from pointer target type wocky-openssl.c:1685:23: error: assignment discards qualifiers from pointer target type make[3]: *** [wocky-openssl.lo] Error 1 make[3]: Leaving directory `/home/Jon/telepathy-gabble/lib/ext/wocky/wocky' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/Jon/telepathy-gabble/lib/ext/wocky/wocky' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/Jon/telepathy-gabble/lib/ext/wocky' make: *** [all] Error 2
Created attachment 49526 [details] [review] Propose #ifndef for when EC is disabled
Comment on attachment 49526 [details] [review] Propose #ifndef for when EC is disabled Review of attachment 49526 [details] [review]: ----------------------------------------------------------------- Looks good to me, just one question for you: ::: wocky/wocky-openssl.c @@ +1693,4 @@ > static void > set_ecdh_key (WockyTLSSession *session) > { > +#ifndef OPENSSL_NO_EC Note sure, but I see there is also an possible OPENSSL_NO_ECDH in config, shall we check both, or this one imply the other one ?
Is there an answer to this question ? I've been waiting for that before proceeding to a merge.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.