Bug 3210 - DoGetFBConfigs sets wrong reply length
Summary: DoGetFBConfigs sets wrong reply length
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Ext/GLX (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Ian Romanick
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-04 20:32 UTC by Jeremy Kolb
Modified: 2005-07-11 15:13 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Jeremy Kolb 2005-05-04 20:32:42 UTC 
The line:
reply.length = (reply.numAttribs * reply.numFBConfigs);
In programs/Server/GL/GLX/glxcmds.c
is wrong.  The GLX spec states that the reply length is numAttribs *
numFBConfigs * 2.  So it needs to be multiplied be 2.
Comment 1 Jeremy Kolb 2005-05-15 21:16:21 UTC 
Not only is this wrong with the protocol but mesa on xcb dies horribly with this
one.  So... BUMP
Comment 2 Ian Romanick 2005-07-05 14:52:27 UTC 
That is correct.  Elsewhere in that routine "__GLX_TOTAL_FBCONFIG_ATTRIBS * 2"
is used, and the same should be used there.  I suspect this may be related to
bug #3539.
Comment 3 Jeremy Kolb 2005-07-05 16:43:00 UTC 
(In reply to comment #2)
> That is correct.  Elsewhere in that routine "__GLX_TOTAL_FBCONFIG_ATTRIBS * 2"
> is used, and the same should be used there.  I suspect this may be related to
> bug #3539.

I was running using mesa 6.x (cvs) locally on an amd athlon thunderbird with
Xorg 6.8.2.
Comment 4 Ian Romanick 2005-07-06 00:18:35 UTC 
I just committed the "obvious" fix for this.  Could you please verify it?  Thanks.
Comment 5 Chris Lee 2005-07-12 23:53:01 UTC 
Ian's commit looks to have fixed this, and nobody has complained since the
commit so I'm closing this.
Comment 6 Jeremy Kolb 2005-07-13 01:13:27 UTC 
(In reply to comment #5)
> Ian's commit looks to have fixed this, and nobody has complained since the
> commit so I'm closing this.

Sorry, haven't had a chance to check... but I trust Ian.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.