Bug 32286 - [SNB need-cherry-pick] case ogles2conform/GL2Tests_framebuffer_objects_input.run causes hard hang
Summary: [SNB need-cherry-pick] case ogles2conform/GL2Tests_framebuffer_objects_input....
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: 7.10
Hardware: Other Linux (All)
: high critical
Assignee: Eric Anholt
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-09 22:02 UTC by Yi Sun
Modified: 2011-03-08 19:16 UTC (History)
6 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Yi Sun 2010-12-09 22:02:44 UTC 
Environment:
------------
platform: HuronRiver(rev 08)
kernel:  (drm-intel-fixes)1b39d6f37622f1da70aa2cfd38bfff9a52c13e05
Libdrm:  (master)2.4.22-21-g537703fd4805e9cd352965fce642670986822d22
Mesa:    (master)05e534e6c4395269b1ca3a9694a1f437363dd186
Xserver:  (server-1.9-branch)xorg-server-1.9.2.902
Xf86_video_intel: (master)2.13.901-25-g9b967807c2d240488a715509649663aac3583532

Bug detailed description:
--------------------------
Case ogles2conform/GL2Tests_framebuffer_objects_input.run causes system hang.
Comment 1 Gordon Jin 2010-12-09 23:12:07 UTC 
It's the only case hang in ogles2conform.
Comment 2 Wang Zhenyu 2010-12-13 21:04:42 UTC 
Sunyi has confirmed this is passed now.
Comment 3 Yi Sun 2010-12-14 22:05:57 UTC 
The bug is a duplicate of #32401.

We have 2 SNB machines, one is Huronriver(rev 08) and the other is Sugarbay(rev 09). So on Huronriver, the system will hang while running the case ogles2conform/GL2Tests_framebuffer_objects_input.run. And the issue still exists now. But on Sugarbay, the issue is just like the description of bug 32401. The system doesn't hang, but X won't start again.

*** This bug has been marked as a duplicate of bug 32401 ***
Comment 4 Yi Sun 2010-12-14 22:51:42 UTC 
Since the different appearance of 2 bugs, we reopen this bug to track the hang issue.

Restate: The system hang issue only occurs on HuronRiver(rev 08) platform.
Comment 5 Wang Zhenyu 2010-12-27 22:14:13 UTC 
This is not hang on my rev08 snb mobile with master. Close this, reopen if still failed for you.
Comment 6 Yi Sun 2010-12-28 20:22:08 UTC 
The case still causes X can't start up correctly, on SugarBay(SNB rev 09).
Comment 7 Wang Zhenyu 2010-12-29 18:19:17 UTC 
Sunyi, please verify mesa master has this fixed, only 7.10 branch needs cherry-pick.
Comment 8 Yi Sun 2010-12-29 18:32:58 UTC 
Yes, mesa master has fixed this bug, but the master branch not.
Comment 9 Gordon Jin 2011-01-04 17:19:53 UTC 
(In reply to comment #8)
> Yes, mesa master has fixed this bug, but the master branch not.

Yi, I assume you meant it happens only on 7.10 branch not master branch, right?
Comment 10 Wang Zhenyu 2011-01-05 21:53:25 UTC 
Need to cherry-pick

commit be72efb4f29180fdaf0935f8739f230fe5ea6317
Author: Eric Anholt <eric@anholt.net>
Date:   Thu Dec 9 17:15:26 2010 -0800

    intel: Just use ChooseTextureFormat for renderbuffer format choice.
    
    One less place to forget to put your new MESA_FORMAT support in.
Comment 11 Yi Sun 2011-01-06 23:37:19 UTC 
The be72efb4f29180fdaf0935f8739f230fe5ea6317 is the first commit which fixed the hang issue.
Comment 12 Eric Anholt 2011-01-07 18:27:01 UTC 
I think what you're actually looking for is commit 29c4f95cbcad29d52bf3b6c875840b38b8823e4c
Comment 13 Wang Zhenyu 2011-01-08 20:21:02 UTC 
oh, right, I forgot the fact that depth must be tiled on gen6. And be72efb4f29180fdaf0935f8739f230fe5ea6317 just made it to hit tiled depth buffer setting on gen6.
Comment 14 Ian Romanick 2011-01-11 16:59:15 UTC 
So... is there something that still needs to be cherry picked to the 7.10 branch?  Is it 29c4f95c, be72efb4, both, or neither?  I'd like to get this bug closed.
Comment 15 Eric Anholt 2011-01-18 12:17:52 UTC 
this should do it:

commit 4e0d6cf7bad7ef15995693d58348fcb7f47120d3
Author: Eric Anholt <eric@anholt.net>
Date:   Fri Jan 7 18:18:50 2011 -0800

    intel: Make renderbuffer tiling choice match texture tiling choice.
    
    There really shouldn't be any difference between the two for us.
    Fixes a bug where Z16 renderbuffers would be untiled on gen6, likely
    leading to hangs.
    (cherry picked from commit 29c4f95cbcad29d52bf3b6c875840b38b8823e4c)
Comment 16 Yi Sun 2011-03-08 19:16:59 UTC 
The commit is already in 7.10 branch. Verified it.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.