Created attachment 40981 [details] new test case for piglit shader_runner This simple code fails on my Calpella today. float f = 8; gl_FragColor = vec4(0, f/10.0, 0, 0.8); Running the attached case gets: Probe at (0,0) Expected: 0.000000 0.800000 0.000000 0.800000 Observed: 0.000000 1.000000 0.000000 0.800000 PIGLIT: {'result': 'fail' } b0fc5103cbc9116806a9888f747baed4b8166246 is the first bad commit commit b0fc5103cbc9116806a9888f747baed4b8166246 Author: Ian Romanick <ian.d.romanick@intel.com> Date: Tue Dec 7 16:27:22 2010 -0800 glsl: Inherrit type of declared variable from initializer
There is one error in that test. The requirements section says 'GLSL >= 1.10', but the GLSL code says '#version 120'. The test clearly requires GLSL >= 1.20.
commit d7f27e2e76eac9bc2ee0fa36f52542fdcb9563dd Author: Ian Romanick <ian.d.romanick@intel.com> Date: Fri Dec 10 15:48:15 2010 -0800 glsl: Inherrit type of declared variable from initializer after processing a do_assignment may apply implicit conversions to coerce the base type of initializer to the base type of the variable being declared. Fixes piglit test glsl-implicit-conversion-02 (bugzilla #32287). This probably also fixes bugzilla #32273. NOTE: This is a candidate for the 7.9 branch and the 7.10 branch.
*** Bug 32273 has been marked as a duplicate of this bug. ***
Ian, thanks for catching that. verified it passes with mesa master.
Marking Resolved/Fixed based on the comments from Ian and Gordon.
We left it open deliberately, waiting for cherry-picking to 7.10 branch. Ken, isn't that your proposal?
commit d3fa3c60f2e12915813eabbbeecc5976d749a9dc Author: Ian Romanick <ian.d.romanick@intel.com> Date: Fri Dec 10 15:48:15 2010 -0800 glsl: Inherrit type of declared variable from initializer after processing assignment do_assignment may apply implicit conversions to coerce the base type of initializer to the base type of the variable being declared. Fixes piglit test glsl-implicit-conversion-02 (bugzilla #32287). This probably also fixes bugzilla #32273. NOTE: This is a candidate for the 7.9 branch and the 7.10 branch. (cherry picked from commit d7f27e2e76eac9bc2ee0fa36f52542fdcb9563dd)
verified on 7.10 branch
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.