Bug 32708 - build script fails during compile of 'connection.c' (function 'AuthAudit') if systemtap 1.2 installed
Summary: build script fails during compile of 'connection.c' (function 'AuthAudit') if...
Status: RESOLVED INVALID
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 7.5 (2009.10)
Hardware: x86 (IA32) Linux (All)
: medium minor
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-28 15:43 UTC by Rick Stockton <AKA rickst29>
Modified: 2018-06-12 18:43 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Rick Stockton <AKA rickst29> 2010-12-28 15:43:52 UTC 
Mandriva 2010.2, in which the RPM is named "systemtap 1.2".

This seems nearly identical to the RedHat BugID 605588 (https://bugzilla.redhat.com/show_bug.cgi?id=605588), but I report this as a bug because comment 6 (written by Nicolas Peninguy) indicates that the error should not occur with xorg-x11-server >= 1.9.3.

But it happens to me on a fresh pull from GIT, following modular build instructions exactly.) Error as follows:

....
connection.c: In function `AuthAudit':
connection.c:589: error: invalid initializer
make[1]: *** [connection.lo] Error 1
make[1]: Leaving directory `/tmp/src/xserver/os'
make: *** [all-recursive] Error 1
***** make failed on xserver/

It could perhaps also be a bug resolved by updating to systemtap >= 1.3.3, as Nicolas would have been using in Fedora-14. Problem is bypassed by removing systemtap 1.2 from my system, and xserver builds successfully.

I enter the bug mostly to create documentation... so please feel free to close it, if you feel that the problem should be addressed by systemtap Devs.
Comment 1 Alan Coopersmith 2010-12-28 16:00:12 UTC 
connection.c:589: error: invalid initializer corresponds to the DTrace
probe call:

    XSERVER_CLIENT_AUTH(client->index, addr, client_pid, client_zid);

This works with actual dtrace, but in that case, it expands to a function call:

#define XSERVER_CLIENT_AUTH(arg0, arg1, arg2, arg3) \
        __dtrace_Xserver___client__auth(arg0, arg1, arg2, arg3)

It sounds like in the systemtap case, the macro is expanding to invalid code,
and I don't know what we can do about that.
Comment 2 Rick Stockton <AKA rickst29> 2010-12-29 16:38:15 UTC 
Thanks for the confirmation (i.e., that xorg server code is "not to blame", the fault occurs from systemtap macro expansion of the client->index Pointer into a an incompatible type).

I'll shortly download and install a newer version of systemtap, and see whether the X11 Server builds successfully in that configuration. In either case, this bug can close at that time-

except, perhaps for an update to the Wiki "Modular Build instructions page", describing issue (minimum systemtap level, or need for removal) in the vicinity of:

http://www.x.org/wiki/ModularDevelopersGuide#Suggestedpackages
Comment 3 Adam Jackson 2018-06-12 18:43:35 UTC 
Mass closure: This bug has been untouched for more than six years, and is not obviously still valid. Please file a new report if you continue to experience issues with a current server.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.