Bug 3292 - Add shadow buffer and rotation support to i830
Summary: Add shadow buffer and rotation support to i830
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: x86 (IA32) FreeBSD
: high enhancement
Assignee: Alan Hourihane
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-14 18:14 UTC by Dima Dorfman
Modified: 2005-05-19 15:24 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch to implement shadowfb and rotate options in the i830 driver (16.40 KB, patch)
2005-05-14 18:17 UTC, Dima Dorfman
no flags Details | Splinter Review

Description Dima Dorfman 2005-05-14 18:14:31 UTC
The attached patch implements shadow framebuffer and screen rotation support in 
the i830 driver. Most of the code was almost directly ported from the savage 
driver. Documentation (man page) update is included.

Delta is against CVS head from a few days ago. The original patch was also based 
on work done by Helmar Spangenberg <hspangenberg@frey.de> (see http://www.mail-
archive.com/devel@xfree86.org/msg06235.html).
Comment 1 Dima Dorfman 2005-05-14 18:17:40 UTC
Created attachment 2679 [details] [review]
Patch to implement shadowfb and rotate options in the i830 driver

The patch is exepcted to be complete. If I forgot something, please let me
know.
Comment 2 Adam Jackson 2005-05-15 17:04:31 UTC
couple of cosmetic comments:

-static const char *driShadowFBSymbols[] = {
+const char *I810shadowFBSymbols[] = {

not that it matters much, but there's no need to make this non-static.

+       xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
+       	   "HW acceleration not supported with \"shadowFB\".\n");

should be \"ShadowFB\"

also i830_shadow.c has some minor whitespace issues.  looks good though!
Comment 3 Alan Hourihane 2005-05-16 02:56:55 UTC
Thanks for the patch. I'll get this integrated.
Comment 4 Alan Hourihane 2005-05-20 08:24:07 UTC
Committed to CVS. Thanks.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.