Bug 32944 - st/mesa: fog is broken in demos/drawpix
Summary: st/mesa: fog is broken in demos/drawpix
Status: RESOLVED MOVED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: low minor
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-09 12:48 UTC by Tormod Volden
Modified: 2019-09-18 20:22 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
drawpix with fog enabled on rv410 (89.94 KB, image/png)
2011-01-09 12:48 UTC, Tormod Volden
Details
Xorg.0.log (29.56 KB, text/plain)
2011-01-09 12:48 UTC, Tormod Volden
Details
glxinfo output (23.44 KB, text/plain)
2011-01-09 12:50 UTC, Tormod Volden
Details

Description Tormod Volden 2011-01-09 12:48:09 UTC
Created attachment 41811 [details]
drawpix with fog enabled on rv410

When enabling fog in the drawpix demo, the fog looks very "digitized" with tiles and edges. See attached screendump for a better impression. For comparison, it looks well and finely distributed on my old savage card. This is gallium on RV410, mesa 7.10 as of today. I also ran the piglit fog tests but they all passed.
Comment 1 Tormod Volden 2011-01-09 12:48:58 UTC
Created attachment 41812 [details]
Xorg.0.log
Comment 2 Tormod Volden 2011-01-09 12:50:19 UTC
Created attachment 41813 [details]
glxinfo output
Comment 3 Marek Olšák 2011-03-01 12:22:48 UTC
Softpipe doesn't render it correctly either. Reassigning to Mesa core.
Comment 4 Brian Paul 2011-03-02 10:37:14 UTC
Looks like the vertex shader isn't passing the fog coordinate to the fragment shader.  In st_cb_drawpix.c the make_passthrough_vertex_shader() function also needs to take a 'fog' parameter and emit a fog result, either computed from the current fog coordinate or as a function of the vertex Z position.

I don't think many people depend on fog with glDrawPixels so this is low priority.
Comment 5 GitLab Migration User 2019-09-18 20:22:23 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/965.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.