Bug 33385 - brw_state_upload.c:236:4: error: ‘_NEW_ACCUM’ undeclared here (not in a function)
Summary: brw_state_upload.c:236:4: error: ‘_NEW_ACCUM’ undeclared here (not in a funct...
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: Other All
: medium major
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-23 11:03 UTC by Cyril Brulebois
Modified: 2011-01-23 13:06 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Cyril Brulebois 2011-01-23 11:03:04 UTC 
Hi,

this commit broke master:

commit fb7efb1b194831cc6cb0b69291949ac693f20f25
Author: Brian Paul <brianp@vmware.com>
Date:   Sun Jan 23 09:48:49 2011 -0700

    mesa: get rid of _NEW_ACCUM, clean-up _NEW_* #defines
    
    The _NEW_ACCUM flag was only set when changing the accumulation
    buffer clear color and never used anywhere.  Reclaim that dirty bit.
    Clean up the definitions of the other dirty bit flags.


Broken build:

brw_state_upload.c:236:4: error: ‘_NEW_ACCUM’ undeclared here (not in a function)

Git grep says:

git grep -l _NEW_ACCUM
src/mesa/drivers/dri/i965/brw_state_upload.c
src/mesa/drivers/windows/gldirect/dx7/gld_driver_dx7.c
src/mesa/drivers/windows/gldirect/dx8/gld_driver_dx8.c
src/mesa/drivers/windows/gldirect/dx9/gld_driver_dx9.c

Putting Brian in Cc as he's the author of that commit.
Comment 1 Brian Paul 2011-01-23 13:06:30 UTC 
Fixed in git.  Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.