Bug 33434 - [nouveau nv84] BUG while reloading module
Summary: [nouveau nv84] BUG while reloading module
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/nouveau (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Nouveau Project
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-24 14:14 UTC by Xavier
Modified: 2011-01-30 14:27 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
dmesg (64.36 KB, text/plain)
2011-01-24 14:15 UTC, Xavier
no flags Details

Description Xavier 2011-01-24 14:14:58 UTC
BUG: unable to handle kernel paging request at ffffffffa024dd8f

git as of today:
kernel: 64b792
drm: 550fe2
ddx: 38e880

01:00.0 VGA compatible controller: nVidia Corporation G84 [GeForce 8600M GT]
(rev a1)
Comment 1 Xavier 2011-01-24 14:15:49 UTC
Created attachment 42411 [details]
dmesg
Comment 2 Ben Skeggs 2011-01-24 14:58:38 UTC
Yeah I've seen this too, very annoying.  I don't believe it was anything in nouveau directly that causes it.  Any chance you could bisect it back to find the offending commit?
Comment 3 Xavier 2011-01-29 14:31:11 UTC
looks like thats the culprit :

commit 3d58ec154bc87b206a3439f064e1c8aa6090c1ee
Author: Lucas Stach <dev@lynxeye.de>
Date:   Thu Jan 6 20:29:53 2011 +0100

    drm/nouveau: fix hwmon device binding
    
    Bind the hwmon structs to nouveau device kobj. This makes sure
    the hwmon files are created in the device subdir in line with
    all other hwmon drivers.
    
    Signed-off-by: Lucas Stach <dev@lynxeye.de>
    Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

diff --git a/drivers/gpu/drm/nouveau/nouveau_pm.c b/drivers/gpu/drm/nouveau/nouveau_pm.c
index d938141..fb846a3 100644
--- a/drivers/gpu/drm/nouveau/nouveau_pm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_pm.c
@@ -422,8 +422,7 @@ nouveau_hwmon_init(struct drm_device *dev)
                return ret;
        }
        dev_set_drvdata(hwmon_dev, dev);
-       ret = sysfs_create_group(&hwmon_dev->kobj,
-                                       &hwmon_attrgroup);
+       ret = sysfs_create_group(&dev->pdev->dev.kobj, &hwmon_attrgroup);
        if (ret) {
                NV_ERROR(dev,
                        "Unable to create hwmon sysfs file: %d\n", ret);
Comment 4 Lucas Stach 2011-01-30 00:26:22 UTC
Oh. This seems my fault. I have not tested with reloading, sorry.

I will look into this today and try to fix it without the need to revert this commit.
Comment 5 Lucas Stach 2011-01-30 02:12:26 UTC
Patch is on the mailing list.
Again sorry for your inconvenience and thanks for your time bisecting this.

I will leave this bug open till the fix is in master.
Comment 6 Xavier 2011-01-30 03:10:24 UTC
I wake up and get the same fix from 2 different persons :)
joi on IRC 12h ago :
00:39   joi >> shining^: http://paste.pocoo.org/show/328947/ <- should fix it

I just applied and it does work, so thank you both.
Comment 7 Ben Skeggs 2011-01-30 14:27:54 UTC
Fixed in nouveau master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.