Bug 33464 - errno isn't thread-safe on Solaris without -D_REENTRANT
Summary: errno isn't thread-safe on Solaris without -D_REENTRANT
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.4.x
Hardware: All Solaris
: medium normal
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 06:41 UTC by Simon McVittie
Modified: 2011-01-27 10:00 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Opt-in to thread safety on Solaris (943 bytes, patch)
2011-01-26 10:24 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2011-01-25 06:41:51 UTC 
Solaris' errno.h apparently needs -D_REENTRANT to make it not suck.

I'm tempted to just say "get a better C library", but the fix is easy.
Comment 1 Simon McVittie 2011-01-26 10:24:54 UTC 
Created attachment 42541 [details] [review]
Opt-in to thread safety on Solaris
Comment 2 Colin Walters 2011-01-27 09:43:14 UTC 
Comment on attachment 42541 [details] [review]
Opt-in to thread safety on Solaris

This looks fine, but can you add a reference to the mailing list thread?  Looks like 
http://lists.freedesktop.org/archives/dbus/2010-December/013902.html

?
Comment 3 Simon McVittie 2011-01-27 10:00:07 UTC 
The original report was <http://lists.freedesktop.org/archives/dbus/2010-November/013796.html>. I think in general it's sufficient to reference mailing list threads from Bugzilla and reference the bug in the commit, but I've added a "see also".

I didn't apply the patch from Pavel's December mail, partly because it addressed several unrelated issues and partly because I couldn't find it in my D-Bus mailbox at the time.

Anyway, fixed in git for 1.4.4 (I think this is fine for 1.4).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.