Bug 3370 - Suggested change for ConfineTo
Summary: Suggested change for ConfineTo
Status: RESOLVED WONTFIX
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: All All
: high normal
Assignee: Peter Hutterer
QA Contact: Xorg Project Team
URL:
Whiteboard: 2011BRB_Reviewed
Keywords:
Depends on:
Blocks: xserver-1.13
  Show dependency tree / graph
 
Reported: 2005-05-23 03:01 UTC by Egbert Eich
Modified: 2016-11-28 04:39 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
Make ConfineToShape jump to the closest postion to the current cursor position inside the shape. (2.21 KB, patch)
2005-05-23 03:02 UTC, Egbert Eich 		no flags Details | Splinter Review
confine_to_shape.diff (2.73 KB, patch)
2009-03-20 04:41 UTC, Stefan Dirsch 		no flags Details | Splinter Review
Show Obsolete (1) View All

Description Egbert Eich 2005-05-23 03:01:13 UTC 
ConfineToShape does not work well: The cursor often times doesn't jum to the
point closest to the current cursor position outside the shape. 
The patch that's going to be attached fixes this. However it exposes some
internals of the RegionRec to the DIX layer. Therefore this code may be debateable.
Comment 1 Egbert Eich 2005-05-23 03:02:39 UTC 
Created attachment 2747 [details] [review]
Make ConfineToShape jump to the closest postion to the current cursor position inside the shape.
Comment 2 Daniel Stone 2007-02-27 01:26:49 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 3 Stefan Dirsch 2007-11-04 09:11:26 UTC 
Egbert? See also Novell Bugzilla #62146.
Comment 4 Stefan Dirsch 2008-11-22 13:57:42 UTC 
Patch no longer applies to current git head.
Comment 5 Stefan Dirsch 2009-03-20 04:41:27 UTC 
Created attachment 24080 [details] [review]
confine_to_shape.diff

Patch against xorg-server 1.6. Hope I didn't break it.
Comment 6 Daniel Stone 2009-08-31 18:07:30 UTC 
punting to 7.6.  peter, thoughts?

exposing RegionRec details to the dix is fine, that abstraction is an utter fallacy anyway.
Comment 7 Stefan Dirsch 2010-04-03 03:05:13 UTC 
Giving up ...
Comment 8 Jeremy Huddleston Sequoia 2011-04-11 14:03:38 UTC 
This bug has been around for many releases and does not seem to have a large impact on users.  Because of this, it does not meet the requirements for inclusion in the stable branch (1.10).

Punting to 1.11.
Comment 9 Jeremy Huddleston Sequoia 2011-09-18 01:32:10 UTC 
Peter, please either review this and merge it to your -next/1.12 tree or close it as not to be fixed.
Comment 10 Jeremy Huddleston Sequoia 2011-12-27 21:57:44 UTC 
Deferring to 1.13 as this is functional change
Comment 11 Peter Hutterer 2016-11-28 04:39:53 UTC 
This is a mass change of bugs. Bugs assigned to me that haven't been updated in the last 3 years are closed as WONTFIX, because, well, let's at least be honest about it.

Please do not re-open unless you have a really good reason to do so (e.g. you're fixing it yourself). If it hasn't been fixed in the last 3 years, it probably won't be fixed anytime soon either. Sorry.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.