Bug 33761 - TpAccountChannelRequest: doesn't expose the TpChannelRequest
Summary: TpAccountChannelRequest: doesn't expose the TpChannelRequest
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ca...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-01-31 07:24 UTC by Guillaume Desmottes
Modified: 2011-02-09 04:18 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Guillaume Desmottes 2011-01-31 07:24:18 UTC
TpAccountChannelRequest currently doesn't expose the underlying TpChannelRequest used during the request. That means that the client can't use for example the Requests_Satisfied property from Handle_Channels.

I suggest to fix this by adding this signal on TpAccountChannelRequest:


 /**
   * TpAccountChannelRequest::got-channel-request:
   * @self: a #TpAccountChannelRequest
   * @channel_request: a #TpChannelRequest having its object-path defined but
   * not guaranteed to be prepared
   *
   * Emitted to let the caller know about the #TpChannelRequest being used
   * to request the channel.
   *
   * This can be useful for example to compare with the #TpChannelRequest
   * objects received from the requests_satisfied argument of
   * #TpSimpleHandlerHandleChannelsImpl to check if the client is asked to
   * handle the channel he just requested.
   *
   * Since: 0.13.UNRELEASED
   */
Comment 1 Guillaume Desmottes 2011-01-31 07:39:06 UTC
After discussion on IRC with Will, we agreed that a signal wasn't very convenient to use. So we'll go for a property (+ accessor) exposing the TpChannelRequest which can be NULL. User can connect to notify: if it wants to know when the property is set.
Comment 3 Guillaume Desmottes 2011-02-09 04:18:29 UTC
Merged; will be in 0.13.13


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.