Bug 33840 - test/Makefile.am dist-hook is crufty and unreliable
Summary: test/Makefile.am dist-hook is crufty and unreliable
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.5
Hardware: Other All
: lowest trivial
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL: http://cgit.freedesktop.org/~smcv/dbu...
Whiteboard:
Keywords: patch
Depends on:
Blocks: dbus-1.5
  Show dependency treegraph
 
Reported: 2011-02-02 07:13 UTC by Simon McVittie
Modified: 2012-03-12 05:03 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Enumerate data files used in the build rather than using find(1) (9.73 KB, patch)
2011-09-26 03:35 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2011-02-02 07:13:00 UTC
+++ This bug was initially created as a clone of Bug #30285 +++

I wrote:
> In a test build, the following distributed files incorrectly embed my build
> directory:
[...]
> I think the culprit is the dist-hook rule in test/Makefile.am.

then fixed the bug by making it even more complex.

wjt replied:
> This hook seems kind of crufty in general. I guess replacing it with an
> explicit EXTRA_DIST list would not be trivial?

Further discussion:

15:09 < smcv> wjt: my first go at #30825 did replace the crufty hook with 
              EXTRA_DIST, but it's a comically long list and has a lot of 
              special cases where files are randomly copied around, so I gave up
15:09 < wjt> hehe
15:09 < smcv> I'll revisit it later
15:09 < wjt> i think i looked at this once and was afraid of it
Comment 1 Simon McVittie 2011-09-26 03:35:28 UTC
Created attachment 51616 [details] [review]
Enumerate data files used in the build rather than using  find(1)

This is more verbose, but I think it's still better.
Comment 2 Will Thompson 2012-02-23 09:08:57 UTC
Comment on attachment 51616 [details] [review]
Enumerate data files used in the build rather than using  find(1)

Review of attachment 51616 [details] [review]:
-----------------------------------------------------------------

Bigger, but more legible. Go for it.
Comment 3 Simon McVittie 2012-03-12 05:03:01 UTC
Thanks, fixed in git for 1.4.20, 1.5.12


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.