Bug 33886 - fix gallium sampler view first_level usage
Summary: fix gallium sampler view first_level usage
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 16:19 UTC by Brian Paul
Modified: 2011-04-07 19:52 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch for softpipe (5.51 KB, patch)
2011-02-03 16:19 UTC, Brian Paul
Details | Splinter Review
patch for r300 (3.75 KB, patch)
2011-02-03 16:20 UTC, Brian Paul
Details | Splinter Review
patch for state tracker (2.74 KB, patch)
2011-02-03 16:20 UTC, Brian Paul
Details | Splinter Review
second patch for state tracker (1.31 KB, patch)
2011-02-03 16:20 UTC, Brian Paul
Details | Splinter Review
patch for r300 rebased (3.82 KB, patch)
2011-03-03 19:23 UTC, Marek Olšák
Details | Splinter Review
patch for llvmpipe (22.90 KB, patch)
2011-03-31 07:08 UTC, Fabian Bieler
Details | Splinter Review

Description Brian Paul 2011-02-03 16:19:11 UTC
This is a bug report to avoid losing Henri Verbeet's patch series which fixes gallium's use of the first_level field of sampler views.

Basically, the texture lod should be computed relative to level==first_level, not level=0.  We have patches for softpipe and r300 but llvmpipe (at least) needs to be updated too.
Comment 1 Brian Paul 2011-02-03 16:19:40 UTC
Created attachment 42910 [details] [review]
patch for softpipe
Comment 2 Brian Paul 2011-02-03 16:20:01 UTC
Created attachment 42911 [details] [review]
patch for r300
Comment 3 Brian Paul 2011-02-03 16:20:21 UTC
Created attachment 42912 [details] [review]
patch for state tracker
Comment 4 Brian Paul 2011-02-03 16:20:43 UTC
Created attachment 42913 [details] [review]
second patch for state tracker
Comment 5 Marek Olšák 2011-03-03 19:23:28 UTC
Created attachment 44101 [details] [review]
patch for r300 rebased

Is there any reason not to commit the patches? They work fine on r300g and softpipe.
Comment 6 Brian Paul 2011-03-03 20:52:45 UTC
I'd like to get this resolved for llvmpipe too.  I just haven't had the time.
Comment 7 Fabian Bieler 2011-03-31 07:08:17 UTC
Created attachment 45093 [details] [review]
patch for llvmpipe
Comment 8 Marek Olšák 2011-04-07 12:53:23 UTC
Brian,

Fabian attached the patch for llvmpipe. Can I now push all of them?
Comment 9 Brian Paul 2011-04-07 17:46:32 UTC
I've taken a look at the llvmpipe changes and they look good.  But I haven't had time to apply all the patches and do any testing yet.

If you've tested with piglit, etc. and everything looks good then go ahead and commit the patches.
Comment 10 Marek Olšák 2011-04-07 19:52:41 UTC
All the variants of the tex-miplevel-selection test pass with softpipe, llvmpipe, and r300g (for the first time!). All patches have been pushed. Closing.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.