Bug 339 - config/cf/Imakefile - Fix install bustage for platforms not using xfree86.cf
Summary: config/cf/Imakefile - Fix install bustage for platforms not using xfree86.cf
Status: VERIFIED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Monolithic (show other bugs)
Version: unspecified
Hardware: x86 (IA32) All
: highest trivial
Assignee: Alexander Gottwald
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 351
  Show dependency treegraph
 
Reported: 2004-03-17 12:46 UTC by Harold L Hunt II
Modified: 2019-06-09 14:01 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Fix install bustage when XFree86Version is not defined (546 bytes, patch)
2004-03-17 12:48 UTC, Harold L Hunt II
no flags Details | Splinter Review
Use XFree86Version and XorgVersion as conditional (563 bytes, patch)
2004-07-27 03:10 UTC, Alexander Gottwald
no flags Details | Splinter Review

Description Harold L Hunt II 2004-03-17 12:46:38 UTC
Platforms that are not using xfree86.cf in their .cf file do not generate the
XFree86-specific date.def and version.def files.  Thus, these files cannot be
installed by the "install" make target which breaks this target for these platforms.

The simple solution here, as used elsewhere in this Imakefile, is to test if
XFree86Version is defined and to only install these files when it is defined.

This patch is required for the install target to work correctly on Cygwin.

Harold
Comment 1 Harold L Hunt II 2004-03-17 12:48:13 UTC
Created attachment 144 [details] [review]
Fix install bustage when XFree86Version is not defined
Comment 2 Harold L Hunt II 2004-03-17 12:48:47 UTC
I will commit this soon barring any unusual protest.

Harold
Comment 3 Egbert Eich 2004-03-18 03:02:18 UTC
Harold, please explain why this should block 213.
Comment 4 Harold L Hunt II 2004-03-19 08:20:26 UTC
Moving 1.0 -> 1.1 blocker.

Harold
Comment 5 Alexander Gottwald 2004-07-27 03:10:58 UTC
Created attachment 527 [details] [review]
Use XFree86Version and XorgVersion as conditional

any objections on this change?
Comment 6 Kevin E. Martin 2004-08-02 19:07:45 UTC
Egbert, do you have any problems with this being checked in at this time?
Comment 7 Kevin E. Martin 2004-08-09 15:39:16 UTC
Patch checked in.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.