Bug 33937 - rarian bundles a copy of tinyxml
rarian bundles a copy of tinyxml
Status: NEW
Product: Rarian
Classification: Unclassified
Component: General
unspecified
Other All
: medium normal
Assigned To: Don Scorgie
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-05 07:48 UTC by Pacho Ramos
Modified: 2011-02-05 07:48 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
rarian-0.8.1-system-tinyxml.patch (2.44 KB, patch)
2011-02-05 07:48 UTC, Pacho Ramos
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos 2011-02-05 07:48:56 UTC
Created attachment 42964 [details] [review]
rarian-0.8.1-system-tinyxml.patch

As reported downstream at:
http://bugs.gentoo.org/show_bug.cgi?id=252920

It includes a copy of tinyxml and, instead, it should allow building against system libraries installed from:
http://www.grinninglizard.com/tinyxml/index.html

Attached patch could be a start, but building fails with the following:

rarian-man.c: In function 'setup_man_path':
rarian-man.c:93: warning: ignoring return value of 'pipe', declared with attribute warn_unused_result
rarian-man.c:94: warning: ignoring return value of 'pipe', declared with attribute warn_unused_result
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -DDATADIR=\"/usr/share\" -DSYSCONFDIR=\"/etc\" -DI_KNOW_RARIAN_0_8_IS_UNSTABLE -march=native -O2 -pipe -MT librarian_la-rarian-info.lo -MD -MP -MF .deps/librarian_la-rarian-info.Tpo -c rarian-info.c -o librarian_la-rarian-info.o >/dev/null 2>&1
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -DDATADIR=\"/usr/share\" -DSYSCONFDIR=\"/etc\" -DI_KNOW_RARIAN_0_8_IS_UNSTABLE -march=native -O2 -pipe -MT librarian_la-rarian-man.lo -MD -MP -MF .deps/librarian_la-rarian-man.Tpo -c rarian-man.c -o librarian_la-rarian-man.o >/dev/null 2>&1
mv -f .deps/librarian_la-rarian-man.Tpo .deps/librarian_la-rarian-man.Plo
/bin/sh ../libtool --tag=CXX   --mode=compile x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I..     -march=native -O2 -pipe -MT rarian-omf.lo -MD -MP -MF .deps/rarian-omf.Tpo -c -o rarian-omf.lo rarian-omf.cpp
mv -f .deps/librarian_la-rarian-info.Tpo .deps/librarian_la-rarian-info.Plo
libtool: compile:  x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I.. -march=native -O2 -pipe -MT rarian-omf.lo -MD -MP -MF .deps/rarian-omf.Tpo -c rarian-omf.cpp  -fPIC -DPIC -o .libs/rarian-omf.o
rarian-omf.cpp: In function 'int process_node(TiXmlNode*, RrnReg*)':
rarian-omf.cpp:119: error: 'DOCUMENT' is not a member of 'TiXmlNode'
rarian-omf.cpp:122: error: 'ELEMENT' is not a member of 'TiXmlNode'
make[2]: *** [rarian-omf.lo] Error 1
make[2]: Leaving directory `/var/tmp/portage/app-text/rarian-0.8.1-r1/work/rarian-0.8.1/librarian'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/app-text/rarian-0.8.1-r1/work/rarian-0.8.1'
make: *** [all] Error 2

Thanks