Bug 33993 - Rename sub-classes properly
Summary: Rename sub-classes properly
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: logger (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: review+ (confirmed on IRC)
Keywords:
Depends on: 33546
Blocks: 27271
  Show dependency treegraph
 
Reported: 2011-02-07 09:33 UTC by Nicolas Dufresne
Modified: 2011-02-08 07:46 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Nicolas Dufresne 2011-02-07 09:33:59 UTC
Subclass are not name in a natural neither conventional way which makes the code less readable. I recommend that while breaking the API we should rename TplEventText into TplTextEvent and TplChannelText into TplTextChannel.
Comment 1 Nicolas Dufresne 2011-02-07 09:37:14 UTC
This work can be found at http://git.collabora.co.uk/?p=user/nicolas/telepathy-logger.git;a=shortlog;h=refs/heads/rename-subclass and is base branch found in bug #33546
Comment 2 Emilio Pozuelo Monfort 2011-02-07 10:48:59 UTC
I trust sed, so I just did a very quick look. Ship it!
Comment 3 Nicolas Dufresne 2011-02-08 07:46:42 UTC
Merged.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.