Bug 34065 - apparently useless code that can go
Summary: apparently useless code that can go
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-09 02:45 UTC by Caolán McNamara
Modified: 2011-06-09 01:39 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
like so (1.19 KB, application/octet-stream)
2011-02-09 02:45 UTC, Caolán McNamara 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caolán McNamara 2011-02-09 02:45:13 UTC 
Created attachment 43157 [details]
like so

My compiler tells me value set but unused, a quick looks suggests the whole block doesn't do anything useful anymore
Comment 1 Kohei Yoshida 2011-02-09 06:20:12 UTC 
Well, in fact, the whole ScTabView::InvertBlockMark() may be unused, since we no longer use inverted range selection any more (replaced by the nicer blue translucent range selection thingie).
Comment 2 Caolán McNamara 2011-02-11 07:29:36 UTC 
Yeah, can only be called if PAINT_INVERT is set, and that's no longer used anywhere.