Bug 34092 - Gabble crashes when quickly connecting and disconnecting from the Internet
Summary: Gabble crashes when quickly connecting and disconnecting from the Internet
Status: RESOLVED INVALID
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium major
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ba...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-02-09 08:12 UTC by Marco Barisione
Modified: 2011-02-25 02:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Marco Barisione 2011-02-09 08:12:40 UTC 
I got some reports of gabble crashing if the Internet connection keeps disappearing and reappearing. The crash is caused by the asserts in disconnect_callbacks() that appear to be wrong: in base-connection.c (in tp-glib) there is a comment “you can go from any state to DISCONNECTED”.
Comment 1 Marco Barisione 2011-02-09 08:57:59 UTC 
http://git.collabora.co.uk/?p=user/bari/telepathy-gabble.git;a=shortlog;h=refs/heads/disconnect-crash-34092 contains a fix for this. Can somebody please review?
Comment 2 Will Thompson 2011-02-11 10:32:48 UTC 
I suppose you could write a test for this by calling Disconnect() during the authentication process?

But the patch looks fine, ship it.
Comment 3 Will Thompson 2011-02-25 02:30:57 UTC 
The surrounding code in connection.c to handle disco queries and otherwise-unhandled IQs was rewritten to use Wocky; so this patch no longer applies.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.