TpAccount has this, so TpConnection probably should as well. Here is a branch that fixes this. Great success! http://cgit.freedesktop.org/~sjokkis/telepathy-glib/log/?h=trivia
That trivia branch has some other small fixes in it, so I made a branch just for this bug: http://cgit.freedesktop.org/~sjokkis/telepathy-glib/diff/?h=fdo%2334148
In a perfect world you'd test the gobject properties, too. And you should add Since: 0.13.UNRELEASED to the gtk-docs. But I'll do that while merging it up. :)
(hmm. actually maybe these should be returning TpConnectionManager and TpProtocol objects. I think I'll change the names of methods/properties to be suffixed with "-name".)
actually, do you mind doing those? :) • Rename the methods and properties to have "name" suffixes, in case in future we want versions that give TpConnectionManager and TpProtocol • Add Since: 0.13.UNRELEASED as the last line of the new docstrings. and then merging can occur :)
(In reply to comment #4) > actually, do you mind doing those? :) > > • Rename the methods and properties to have "name" suffixes, in case in future > we want versions that give TpConnectionManager and TpProtocol I agree that these names make more sense, but that would make it inconsistent with the properties in TpAccount (which of course have identical values to these). I think a better solution (at least in a perfect world) is to rename these properties as you suggest, and also rename the corresponding properties in TpAccount. Alternately, we could just go ahead and make both TpAccount and TpConnection return TpConnectionManager/TpProtocol. Both of those solutions break the API though, so cue debate. > • Add Since: 0.13.UNRELEASED as the last line of the new docstrings. Done > > and then merging can occur :) Hooray
Thanks! Merged (with a couple of tiny changes: I fixed the -sections.txt file for renaming, and added tests for the GObject properties alongside the accessors). Will be in 0.13.16. <http://git.collabora.co.uk/?p=telepathy-glib.git;a=commit;h=c8a81c53705cf59e051e3b78bfd3b8f17653c0e2>
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.