Filter all 0.0.0.0 addresses from being sent to the other end of the wire when
using Xdmcp. Suggested on firstname.lastname@example.org and discussed by many people in
that and other forums.
This affects Cygwin specifically because Windows returns the address 0.0.0.0 for
any enabled but unconfigured NICs in the system, such as a wireless card that is
not currently getting a signal or a wired NIC with the cable unplugged. Sending
0.0.0.0 over the wire to an XDM server causes that XDM server to attempt to
connect only to the 0.0.0.0 address rather than to a valid address; the
connection then fails and the Xdmcp session is aborted. This patch prevents
that from happening on such platforms.
Created attachment 150 [details] [review]
Prune 0.0.0.0 address in os/access.c
I will commit this soon if no one complains. It has been build tested on Cygwin
and used in the Cygwin production builds since 2004/01/28 without problems.
I haven't looked at the code in detail, but shouldn't you test for
family == FamilyInternet?
How come we only check for localhost at the first location?
Since this check is done so often why not create a macro?
Moving 1.0 -> 1.1 blocker.
*** This bug has been marked as a duplicate of 784 ***