Bug 342 - Prune addresses in os/access.c
Summary: Prune addresses in os/access.c
Status: RESOLVED DUPLICATE of bug 784
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: All All
: highest minor
Assignee: Harold L Hunt II
QA Contact:
Depends on:
Blocks: 351
  Show dependency treegraph
Reported: 2004-03-17 16:27 UTC by Harold L Hunt II
Modified: 2004-07-26 10:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Prune address in os/access.c (2.72 KB, patch)
2004-03-17 16:27 UTC, Harold L Hunt II
no flags Details | Splinter Review

Description Harold L Hunt II 2004-03-17 16:27:16 UTC
Filter all addresses from being sent to the other end of the wire when
using Xdmcp.  Suggested on devel@xfree86.org and discussed by many people in
that and other forums.

This affects Cygwin specifically because Windows returns the address for
any enabled but unconfigured NICs in the system, such as a wireless card that is
not currently getting a signal or a wired NIC with the cable unplugged.  Sending over the wire to an XDM server causes that XDM server to attempt to
connect only to the address rather than to a valid address; the
connection then fails and the Xdmcp session is aborted.  This patch prevents
that from happening on such platforms.

Comment 1 Harold L Hunt II 2004-03-17 16:27:40 UTC
Created attachment 150 [details] [review]
Prune address in os/access.c
Comment 2 Harold L Hunt II 2004-03-17 16:29:12 UTC
I will commit this soon if no one complains.  It has been build tested on Cygwin
and used in the Cygwin production builds since 2004/01/28 without problems.

Comment 3 Egbert Eich 2004-03-18 03:06:31 UTC
I haven't looked at the code in detail, but shouldn't you test for 
family == FamilyInternet? 
How come we only check for localhost at the first location?
Since this check is done so often why not create a macro?
Comment 4 Harold L Hunt II 2004-03-19 08:20:47 UTC
Moving 1.0 -> 1.1 blocker.

Comment 5 Alexander Gottwald 2004-07-27 03:14:58 UTC

*** This bug has been marked as a duplicate of 784 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.