Bug 3423 - autogen.sh --disable-png; make # Fails
Summary: autogen.sh --disable-png; make # Fails
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: png functions (show other bugs)
Version: 0.9.3
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-29 02:54 UTC by Steve Chaplin
Modified: 2005-08-22 00:14 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Steve Chaplin 2005-05-29 02:54:38 UTC
$ autogen.sh --disable-png; make
fails with hundreds of errors like:
"undefined reference to `cairo_surface_write_to_png'"

libcairotest needs to have a "#ifdef CAIRO_HAS_PNG_FUNCTIONS" wrapper,
or if all the tests actually depend on png, they should be disabled 
completely.
Comment 1 Owen Taylor 2005-07-23 00:24:35 UTC
Or just remove the --disable-png option...
Comment 2 Billy Biggs 2005-07-28 14:44:30 UTC
Created attachment 3170 [details] [review]
Fix crash on cmap alloc failure and fix failure with 32 bits visual
Comment 3 Owen Taylor 2005-07-29 03:32:16 UTC
Created attachment 3183 [details]
SSH key for account request

Here's something I like better than adding a bunch of conditionals to
tests/Makefile.am
Comment 4 Owen Taylor 2005-07-29 03:32:59 UTC
(The last patch not extensively tested, seems to work with libpng present)
Comment 5 Owen Taylor 2005-07-29 03:44:20 UTC
2005-07-28  Owen Taylor  <otaylor@redhat.com>

        * configure.in Makefile.am: Skip tests/ directory if
        libpng was disabled. (#3423, reported by Steve Chaplin)
Comment 6 Carl Worth 2005-08-22 17:14:30 UTC
Move bugs against "cvs" version to "0.9.3" so we can remove the "cvs" version.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.