Bug 34266 - configs silently ignored if libxml2 doesn't support SAX1 interface
Summary: configs silently ignored if libxml2 doesn't support SAX1 interface
Status: RESOLVED FIXED
Alias: None
Product: fontconfig
Classification: Unclassified
Component: library (show other bugs)
Version: 2.8
Hardware: All All
: lowest minor
Assignee: Akira TAGOH
QA Contact: Behdad Esfahbod
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-14 10:10 UTC by Jakub Wilk
Modified: 2012-07-05 00:28 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Bug 34266 - configs silently ignored if libxml2 doesn't support SAX1 interface (1.04 KB, patch)
2012-07-03 03:59 UTC, Akira TAGOH
Details | Splinter Review

Description Jakub Wilk 2011-02-14 10:10:13 UTC
If fontconfig was built against libxml2 and libxml2 wasn't compiled with the --with-sax1 option, then the fontconfig XML parser would silently ignore contents of any configuration file.

Either fcxml.c should either be ported to the newer SAX2 interface or it should fail to build if LIBXML_SAX1_ENABLED is not defined.
Comment 1 Behdad Esfahbod 2011-03-14 13:36:23 UTC
Got patch?
Comment 2 Akira TAGOH 2012-07-03 03:59:03 UTC
Created attachment 63758 [details] [review]
Bug 34266 - configs silently ignored if libxml2 doesn't support SAX1 interface

Check in configure if libxml2 has built with --with-sax1
Comment 3 Akira TAGOH 2012-07-03 04:00:52 UTC
It's easy to add instead of modifying the code for SAX2 support... though eventually we need to implement it, it works enough so far.
Comment 4 Akira TAGOH 2012-07-05 00:28:56 UTC
merged into git master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.