Bug 34332 - [r300g, bisected] HoN: corruption with tiling and CS ioctl thread offloading
Summary: [r300g, bisected] HoN: corruption with tiling and CS ioctl thread offloading
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/r300 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2011-02-16 03:35 UTC by Pavel Ondračka
Modified: 2011-02-16 13:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
screenshot (716.31 KB, image/png)
2011-02-16 03:35 UTC, Pavel Ondračka 		Details
possible fix (7.18 KB, patch)
2011-02-16 13:25 UTC, Marek Olšák 		Details | Splinter Review
View All

Description Pavel Ondračka 2011-02-16 03:35:24 UTC 
Created attachment 43425 [details]
screenshot

There is corruption in Heroes of Newerth menu and also ingame.

b9e2cde6006b557a3a23a82384899f4d5a5ac7b8 is the first bad commit
commit b9e2cde6006b557a3a23a82384899f4d5a5ac7b8
Author: Marek Olšák <maraeo@gmail.com>
Date:   Tue Feb 15 05:43:44 2011 +0100

    r300g: offload the CS ioctl to another thread
    
    This is a multi-threading optimization which hides the kernel overhead
    behind a thread. It improves performance in CPU-limited apps by 2-15%.
    Of course you must have at least 2 cores for it to make any difference.
    
    It can be disabled with:
    
    export RADEON_THREAD=0

RADEON_THREAD=0 or RADEON_DEBUG=notiling solves this bug.

The screenshot is taken without libtxc_dxtn. The corruption is much better when libtxc_dxtn is present, but not completely gone.

GPU: RV530
mesa: f53436d821a5173075b2a4a8db8cd23d9669f6e2
kernel: 2.6.37
Comment 1 Marek Olšák 2011-02-16 13:25:45 UTC 
Created attachment 43454 [details] [review]
possible fix

Does this patch fix the issue?
Comment 2 Pavel Ondračka 2011-02-16 13:40:36 UTC 
(In reply to comment #1)
> Created an attachment (id=43454) [details]
> possible fix
> 
> Does this patch fix the issue?

Yes, your patch fixes it. Thank you.
Comment 3 Marek Olšák 2011-02-16 13:53:18 UTC 
OK, committed, closing...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.