Bug 34349 - TplEventSearchType not used or documented properly
Summary: TplEventSearchType not used or documented properly
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: logger (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Nicolas Dufresne
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ni...
Whiteboard:
Keywords: patch
Depends on:
Blocks: 27271
  Show dependency tree / graph
 
Reported: 2011-02-16 10:16 UTC by Nicolas Dufresne
Modified: 2011-02-24 08:47 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Nicolas Dufresne 2011-02-16 10:16:13 UTC 
In certain function, this enumeration seems not to be used as Flags, which is odd. Most of the time, it is used to differentiate contact target ID, form room target ID. This should instead the TplEntityType from TplEntity object as the target is mainly an entity. Also, in current search function, this flag is simply not used, which is also odd and need to be reviewed.
Comment 1 Nicolas Dufresne 2011-02-23 07:51:31 UTC 
The main problem is that TplEventSearchType type mixes the notion of target type (is_room or not) with some search flags. The approach in this patch is to use TplEntity object (which contains the type) and create a new enumeration for type masking called TplEventTypeMask.
Comment 2 Nicolas Dufresne 2011-02-24 08:47:28 UTC 
Fixed in 0.2.0 after Emilio (pochu) quick review.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.