Bug 34468 - src/glsl/Makefile fix
Summary: src/glsl/Makefile fix
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: All All
: medium normal
Assignee: Kenneth Graunke
QA Contact:
Depends on:
Reported: 2011-02-18 18:41 UTC by Chistopher Krakowiak
Modified: 2011-02-19 07:16 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

simple patch insetad of sed rule (579 bytes, patch)
2011-02-18 19:13 UTC, Chistopher Krakowiak
Details | Splinter Review

Description Chistopher Krakowiak 2011-02-18 18:41:06 UTC
Somebody else told me solution, dunno if the reason(for not working on some systems) is symlinked bash as ksh or something else, but it works:

sed -i 's/$(PWD)/$(CURDIR)/' src/glsl/Makefile fix

I am also attaching patch.

To clarify, I am using PLD Th(2.99), where software is fresh-to-bleeding_edge, so its impossible that I needed patching because of deprecated tools, and probably this bug will appear on other distros adter updating.
Comment 1 Chistopher Krakowiak 2011-02-18 19:13:32 UTC
Created attachment 43542 [details] [review]
simple patch insetad of sed rule
Comment 2 Kenneth Graunke 2011-02-19 00:10:24 UTC
I'm not really sure what the concern is...the title and comments here only suggest fixes for some unknown problem.  Presumably it's failing to build on your system.

Hopefully the following commit fixes it:

commit b1002e4aa50a634f5663eb416e9a0a582fb95633
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Sat Feb 19 00:06:00 2011 -0800

    glsl: Remove $(PWD) from Makefile in favor of .
    Hopefully should fix bug #34468.

I don't think we actually need an absolute path in the first place.

Please reopen if this doesn't actually fix the problem.
Comment 3 Chistopher Krakowiak 2011-02-19 07:16:17 UTC
Thx, simple dot fixes everything ;)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.