Bug 3454 - fc-lang cannot handle CR/LF line endings
Summary: fc-lang cannot handle CR/LF line endings
Status: RESOLVED FIXED
Alias: None
Product: fontconfig
Classification: Unclassified
Component: library (show other bugs)
Version: 2.3
Hardware: x86 (IA32) Windows (All)
: high blocker
Assignee: Keith Packard
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-02 08:26 UTC by Daniel Stone
Modified: 2006-02-21 20:51 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
fixes the CR/LF line ending problem (648 bytes, patch)
2005-06-02 08:28 UTC, FreeDesktop Bugzilla Database Corruption Fix User 		Details | Splinter Review
View All

Description FreeDesktop Bugzilla Database Corruption Fix User 2005-06-02 08:26:08 UTC 
Hi,

fc-lang cannot process the "include" statement in the *.orth files when they are
saved with DOS line endings (CR/LF).

Regards,
Mark
Comment 1 FreeDesktop Bugzilla Database Corruption Fix User 2005-06-02 08:28:55 UTC 
Created attachment 2816 [details] [review]
fixes the CR/LF line ending problem

now it tests for both CR and LF in a while() loop to catch both if they exist
Comment 2 Keith Packard 2005-06-02 21:26:10 UTC 
This function should probably strip all whitespace on both sides of the filename.

Could you provide a patch using 'isspace' instead of this explicit test against
the two characters?
Comment 3 Patrick Lam 2006-02-22 15:51:06 UTC 
I committed a modified version of this patch, pulling up the \r stripping to
get_line.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.