Bug 34580 - [PATCH] Reference leak in fs_rtp_stream_set_negotiated_codecs_unlock()
[PATCH] Reference leak in fs_rtp_stream_set_negotiated_codecs_unlock()
Status: RESOLVED FIXED
Product: Farstream
Classification: Unclassified
Component: RTP Plugin
unspecified
All All
: medium normal
Assigned To: Olivier Crête
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-22 13:45 UTC by Jakub Adam
Modified: 2011-02-22 14:46 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Reference leak patch (767 bytes, patch)
2011-02-22 13:45 UTC, Jakub Adam
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Adam 2011-02-22 13:45:57 UTC
Created attachment 43678 [details] [review]
Reference leak patch

Hi,

there is a reference leak in fs_rtp_stream_set_negotiated_codecs_unlock(), when fs_codec_list_are_equal() is TRUE, we should unref the FsRtpSession reference we obtained by calling fs_rtp_stream_get_session(). Patch is attached.

BR

Jakub
Comment 1 Olivier Crête 2011-02-22 14:46:12 UTC
Thanks, patch applied