Until xf86-input-mouse-1.6.0, the MousePreInit() function exited if an os specific PreInit function existed. It let the os-specific function finish all initialisations that remained to be done after osInfo->PreInit() was called. The code in master now continues, and does things that the bsdMousePreInit() function in bsd_mouse.c doesn't expect. I don't have time to look at this deeper for now, but please don't release xf86-input-mouse 1.7 before this is fixed.
Created attachment 43898 [details] [review] Fix patch Try this patch, it must fix
(In reply to comment #1) > Created an attachment (id=43898) [details] > Fix patch > > Try this patch, it must fix Yes it fixes the issue. However I think that for the long term a better solution is needed: - treat the wsmouse protocol as a 1st class protocol in mouse.c - review and remove code duplication between the OS PreInit code and the generic one.
Created attachment 44158 [details] [review] ver 2
Review of attachment 44158 [details] [review]: I think the PreInit hunk should be folded into MousePickProtocol.
Created attachment 44192 [details] [review] ver 3 Move PreInit in MousePickProtocol
(In reply to comment #5) > Created an attachment (id=44192) [details] > ver 3 > > Move PreInit in MousePickProtocol Looks good to me and works. Tested-by: Matthieu Herrb <matthieu.herrb@laas.fr> Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr>
Review of attachment 44192 [details] [review]: Can we move this into the switch statement? we already have special casing for PROT_UNKNOWN and PROP_UNSUP, so adding another special case there seems to be the better place.
Created attachment 44226 [details] [review] ver 4 Move PreInit into the switch statement. Good idea, thanks.
ack by me. Matthieu, can you please re-test the latest version and I'll push it. anything else needed before we release the next version? Alexandr, just noticed this now, can you please attach this as signed-off git-formatted patch. thanks. http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches
Created attachment 44276 [details] [review] ver 4 (git-formatted patch)
Review of attachment 44276 [details] [review]: Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr>
(In reply to comment #9) > ack by me. Matthieu, can you please re-test the latest version and I'll push > it. anything else needed before we release the next version? > No problem with version 4. I can't think of anything else blocking a release, although I didn't test any real serial protocol (can't find any old serial mouse around the attic here). > Alexandr, just noticed this now, can you please attach this as signed-off > git-formatted patch. thanks. > http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches
commit a22879c6779283684fe4a61543fc95179b4f5d0b Author: Alexandr Shadchin <Alexandr.Shadchin@gmail.com> Date: Wed Mar 9 20:09:59 2011 +0500 Fix BSD issues with new ABI12 init process.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.