Bug 34886 - Fonts in GTK apps look ugly with LCD patch (from bug 10301)
Summary: Fonts in GTK apps look ugly with LCD patch (from bug 10301)
Status: RESOLVED INVALID
Alias: None
Product: cairo
Classification: Unclassified
Component: general (show other bugs)
Version: 1.10.2
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Carl Worth
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-01 15:04 UTC by Ahmad Samir
Modified: 2011-03-14 15:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
~/.fonts.conf (527 bytes, text/plain)
2011-03-01 15:04 UTC, Ahmad Samir
Details
file-roller, on the left official tarball; on the right with the commit reverted (82.80 KB, image/png)
2011-03-01 15:06 UTC, Ahmad Samir
Details
Some text in firefox. The one at the top is the official tarball; the one at the bottom is with the commit reverted (146.44 KB, image/png)
2011-03-01 15:09 UTC, Ahmad Samir
Details

Description Ahmad Samir 2011-03-01 15:04:24 UTC
Created attachment 43988 [details]
~/.fonts.conf

I've been experiencing some jagged-looking fonts in GTK apps with Cairo > 1.8.8; I've narrowed it down to changes between 1.9.8 and 1.9.10. Reverting this commit:
http://cgit.freedesktop.org/cairo/commit/?id=7a023a62f7517ad0d54f4d59c99909fadcc05e82

made fonts looks better. See the attached screenshots.

I am using cairo-1.10.2, freetype2-2.4.4 (default upstream, i.e. the bytecode interpreter is enabled, but sub-pixel rendering is disabled (due to patents)).

$ xrdb -q
Xcursor.theme:  Oxygen_Black
Xft.antialias:  1
Xft.autohint:   0
Xft.dpi:        101
Xft.hinting:    1
Xft.hintstyle:  hintfull
Xft.rgba:       rgb

Attached is ~/.fonts.conf, and screen shots comparing official 1.10.2 tarball; and 1.10.2 patched to revert the afro-mentioned commit.
Comment 1 Ahmad Samir 2011-03-01 15:06:09 UTC
Created attachment 43989 [details]
file-roller, on the left official tarball; on the right with the commit reverted
Comment 2 Ahmad Samir 2011-03-01 15:09:21 UTC
Created attachment 43990 [details]
Some text in firefox. The one at the top is the official tarball; the one at the bottom is with the commit reverted
Comment 3 Andrea Canciani 2011-03-08 00:51:14 UTC
(In reply to comment #0)
> Created an attachment (id=43988) [details]
> ~/.fonts.conf
> 
> I've been experiencing some jagged-looking fonts in GTK apps with Cairo >
> 1.8.8; I've narrowed it down to changes between 1.9.8 and 1.9.10. Reverting
> this commit:
> http://cgit.freedesktop.org/cairo/commit/?id=7a023a62f7517ad0d54f4d59c99909fadcc05e82
> 
> made fonts looks better. See the attached screenshots.
> 
> I am using cairo-1.10.2, freetype2-2.4.4 (default upstream, i.e. the bytecode
> interpreter is enabled, but sub-pixel rendering is disabled (due to patents)).

That commit replaces a cairo-internal implementation of subpixel filtering with
the appropriate api calls to freetype. This respects your system settings and does
not work around your freetype library, hence to get subpixel filtering you should
use a freetype library with subpixel enabled.

Can you confirm if enabling subpexel in freetype fixes your problem?
Comment 4 Ahmad Samir 2011-03-08 15:51:41 UTC
(In reply to comment #3)
> That commit replaces a cairo-internal implementation of subpixel filtering with
> the appropriate api calls to freetype. This respects your system settings and
> does
> not work around your freetype library, hence to get subpixel filtering you
> should
> use a freetype library with subpixel enabled.
> 
> Can you confirm if enabling subpexel in freetype fixes your problem?

Yes, using freetype with enabling subpixel rendering at build time, I get similar looking fonts (similar to the "good" fonts in the attached ^ screenshots) with lcdlegacy filter.

So this is not a bug/regression? .. so now I have to enable a patent-covered feature in freetype2 to use freetype's legacy subpixel rendering, right?
Comment 5 Ahmad Samir 2011-03-14 15:46:49 UTC
Re-reading you comment again, I see that this bug is actually invalid.

Thanks :)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.