Bug 35367 - RV670 AGP lodbias regression since st/mesa: remove unnecessary flushes
Summary: RV670 AGP lodbias regression since st/mesa: remove unnecessary flushes
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/r600 (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-16 13:18 UTC by Andy Furniss
Modified: 2011-05-06 06:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Andy Furniss 2011-03-16 13:18:58 UTC
rv670 AGP but running agpmode=-1 as agpgart + gallium locks on this box.
kernel d-r-t, git ddx with tiling enabled in xorg.conf.
Does not affect my PCIE RV790 box.

Mesa demo lodbias does not work normally since 

commit bdf103894026238c7e896eccb995b141161bfb70
Author: Marek Olšák <maraeo@gmail.com>
Date:   Tue Mar 8 00:28:33 2011 +0100

    st/mesa: remove unnecessary flushes
    
    The framebuffer cache flush should be implicit when calling
    set_framebuffer_state.
    
    There is no need to flush the command stream either.


It disappears to black too quickly between 1.5 and 2.5 and the image is corrupt rather than blurring gradually during this time.
Comment 1 Andy Furniss 2011-04-15 04:43:15 UTC
(In reply to comment #0)
> rv670 AGP but running agpmode=-1 as agpgart + gallium locks on this box.
> kernel d-r-t, git ddx with tiling enabled in xorg.conf.
> Does not affect my PCIE RV790 box.
> 
> Mesa demo lodbias does not work normally since 
> 
> commit bdf103894026238c7e896eccb995b141161bfb70
> Author: Marek Olšák <maraeo@gmail.com>
> Date:   Tue Mar 8 00:28:33 2011 +0100
> 
>     st/mesa: remove unnecessary flushes
> 
>     The framebuffer cache flush should be implicit when calling
>     set_framebuffer_state.
> 
>     There is no need to flush the command stream either.
> 
> 
> It disappears to black too quickly between 1.5 and 2.5 and the image is corrupt
> rather than blurring gradually during this time.

fixed by patch in -

https://bugs.freedesktop.org/show_bug.cgi?id=35312
Comment 2 Marek Olšák 2011-04-15 13:27:28 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > rv670 AGP but running agpmode=-1 as agpgart + gallium locks on this box.
> > kernel d-r-t, git ddx with tiling enabled in xorg.conf.
> > Does not affect my PCIE RV790 box.
> > 
> > Mesa demo lodbias does not work normally since 
> > 
> > commit bdf103894026238c7e896eccb995b141161bfb70
> > Author: Marek Olšák <maraeo@gmail.com>
> > Date:   Tue Mar 8 00:28:33 2011 +0100
> > 
> >     st/mesa: remove unnecessary flushes
> > 
> >     The framebuffer cache flush should be implicit when calling
> >     set_framebuffer_state.
> > 
> >     There is no need to flush the command stream either.
> > 
> > 
> > It disappears to black too quickly between 1.5 and 2.5 and the image is corrupt
> > rather than blurring gradually during this time.
> 
> fixed by patch in -
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=35312

This is a driver-specific bug and the patch in bug 35312 is not a fix, it's a bloody hack.
Comment 3 Andy Furniss 2011-05-06 06:46:09 UTC
fixed in mesa master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.