Bug 35483 - util_blit_pixels_writemask: crash in line 322 of src/gallium/auxiliary/util/u_blit.c
util_blit_pixels_writemask: crash in line 322 of src/gallium/auxiliary/util/u...
Status: RESOLVED FIXED
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/r300
7.10
x86 (IA32) Linux (All)
: medium critical
Assigned To: Default DRI bug account
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-21 00:36 UTC by Kai
Modified: 2011-03-29 15:53 UTC (History)
0 users

See Also:


Attachments
Backtrace of the crash (Tropico with Wine 1.3.16) (15.99 KB, text/plain)
2011-03-21 00:36 UTC, Kai
Details
patch (707 bytes, patch)
2011-03-21 02:28 UTC, Henri Verbeet
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kai 2011-03-21 00:36:37 UTC
Created attachment 44648 [details]
Backtrace of the crash (Tropico with Wine 1.3.16)

When switching to (or starting a game when the last setting was) the hardware accelerated mode in Tropico, the game immediately crashes with the attached backtrace.

Please note, that I wasn't able to attach an GDB to Wine/Tropic, if I do, I get tons of SIGSEGVs in Tropico before I get anywhere close to this bug. So I fear the Wine-generated backtrace must do. If you need further information, beyond the following, please let me know.

DDX: 6.14.0
X.org: 1.9.4.901 (1.9.5 RC 1)
Kernel: 2.6.38
libdrm2: 2.4.24
Mesa: 7.10

The "Severity" was set in accordance with <https://bugs.freedesktop.org/page.cgi?id=fields.html#bug_severity> where a crash is named as critical.
Comment 1 Henri Verbeet 2011-03-21 02:28:04 UTC
Created attachment 44652 [details] [review]
patch

You can't tell from the backtrace, but I think I know what this is. Wine sometimes does FBO blits directly to the front buffer. This currently tends to crash due to the front buffer surface not being created yet. The attached patch should help with the crash, but it may not be enough to make the actual blit work correctly.
Comment 2 Kai 2011-03-21 04:41:34 UTC
(In reply to comment #1)
> You can't tell from the backtrace, but I think I know what this is. Wine
> sometimes does FBO blits directly to the front buffer. This currently tends to
> crash due to the front buffer surface not being created yet. The attached patch
> should help with the crash, but it may not be enough to make the actual blit
> work correctly.

Your guess was right, the patch from attachment 44652 [details] [review] fixes the bug. Tropico works perfectly now with hardware 3D acceleration enabled (though it's a little bit slow).
Comment 3 Marek Olšák 2011-03-29 15:53:57 UTC
Fixed by Henri's commit 5d7c27f5ec2f30c264dc2d53c4980970b3a13ee5. I am cherry-picking it to the 7.9 and 7.10 branches. Closing.