Bug 35786 - regression in gnome-shell dialog rendering.
Summary: regression in gnome-shell dialog rendering.
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Chris Wilson
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 00:22 UTC by Dave Airlie
Modified: 2011-04-02 01:34 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Dave Airlie 2011-03-30 00:22:44 UTC 
Original report is here:

https://bugzilla.gnome.org/show_bug.cgi?id=646113

bisecting points out


f627d429bda8196fd20f2023374ad6d34e4becb6 : intel: Add some defense against bo allocation failure

but to fix it on master i have to revert

f627d429bda8196fd20f2023374ad6d34e4becb6 : intel: Add some defense against bo allocation failure
de7678ef521f4fb34459e407a66ab8bf8be733e1 : intel: Add some defense against buffer allocation failure for subimage blits
6547253bd138db815173c00ca2dc220e8ad20ab1 : intel: check for miptree allocation failure
Comment 1 Chris Wilson 2011-03-30 03:17:35 UTC 
Applied the revert, and hopefully done the right allocation checking this time...

commit f5a9a0bc22c4b717c2c32f4ddf283878d6c7ba93
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Mar 30 10:54:31 2011 +0100

    Revert "intel: Add some defense against buffer allocation failure for subima
    
    This reverts commit de7678ef521f4fb34459e407a66ab8bf8be733e1.
    
    The conversion from using drm_intel_bo_alloc_tiled to a plain
    drm_intel_bo_alloc forgot that the tiled variant adjusts the
    allocation height even for TILING_NONE.
    
    Reported-by: Dave Airlie <airlied@redhat.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=35786
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>


commit 5eb9f687087a4bc71775a32efcd848fc6cd67694
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Fri Mar 4 15:04:36 2011 +0000

    intel: Add some defense against buffer allocation failure for subimage blits
    
    Once more! This time without the unwarranted conversion from
    drm_intel_bo_alloc_tiled.
    
    Signed-off-by: [a very embarrassed] Chris Wilson <chris@chris-wilson.co.uk>
Comment 2 Chris Wilson 2011-04-02 01:34:43 UTC 
Trusting Dave's diagnosis and subsequent patch...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.