Bug 35793 - never-ending loop in text-channel:pendingproc_store_pending_messages
Summary: never-ending loop in text-channel:pendingproc_store_pending_messages
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: logger (show other bugs)
Version: git master
Hardware: Other All
: medium major
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-30 03:32 UTC by Sjoerd Simons
Modified: 2011-04-15 09:53 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Sjoerd Simons 2011-03-30 03:32:08 UTC 
Hey,

I noticed that my logger sometimes goes and uses 100% cpu, which is not great. A bit more research showed that the loop in store_pending_messages does..

if (cached->id == pending_id)
else if (cached->id < pending_id)
else if (cached->id < pending_id)

One of the two final ones should probably have a >, but i didn't dive deep enough into the logic to determine which one ;)
Comment 1 Nicolas Dufresne 2011-03-30 10:00:01 UTC 
Fixed in commit 884c52dad5d5fb30a450b013b83aed306ed49164, will be included in next release (0.2.8)
Comment 2 Nicolas Dufresne 2011-03-30 13:57:29 UTC 
(In reply to comment #1)
> Fixed in commit 884c52dad5d5fb30a450b013b83aed306ed49164, will be included in
> next release (0.2.8)

Correction, I forgot to push the 0.2.7 tag and news last time, so this patch made it for 0.2.7.
Comment 3 Nicolas Dufresne 2011-04-15 09:53:07 UTC 
*** Bug 36259 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.