Bug 36022 - [i965]glean/pixelFormats failed
Summary: [i965]glean/pixelFormats failed
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: git
Hardware: All Linux (All)
: high major
Assignee: Ian Romanick
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 02:36 UTC by fangxun
Modified: 2011-04-07 19:50 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description fangxun 2011-04-06 02:36:34 UTC
System Environment:
--------------------------
Arch:           x86_64
Platform:       piketon
Libdrm:   (master)2.4.24-10-gf395b0a25c9f99688e7b2799ac02f1f930f24e09
Mesa:     (master)6caac3ecb8bc32d92c35fdb1f0a67541ffa8af29
Xserver:(master)xorg-server-1.10.0-162-gf9834d312e3059073e8ad77d9f9d57cb9d96e1e5
Xf86_video_intel:  (master)2.14.902-19-g5f31025ccea960a1d6b9c52582443dcc9e137f88
Kernel: (drm-intel-next)3fb033577341fc19b2803b411572e08fb0391baf


Bug detailed description:
-------------------------
This issue happens on ironlake and SNB. It passed before commit 48024fb and segfault since this commit. After commit e21bea(Pls see bug 33046), it still fails with errors in dmesg: "glean[16967] trap divideerror ip:7fe7a1812ac1 sp:7fff6ff94220 error:0 in i965_dri.so[7fe7a17cf000+38e000]".


Reproduce steps:
-------------------------
1. start X
2. ./glean -r pixelFormats -o -v -v -v -t +pixelFormats
Comment 1 Ian Romanick 2011-04-06 09:47:26 UTC
Should be fixed on master by the commits below.  This bug shouldn't exist on 7.9 or 7.10 branches because the changes that caused it do not exist there.

commit e397b3a7c051b70a574e34096b70fc98e4e84b2c
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Sat Apr 2 18:56:33 2011 -0700

    mesa: Add fall-back formats for unsupported snorm formats
    
    This is always the way with real hardware and desktop OpenGL.  Some
    hardware can't do some formats natively.  The alpha-only, luminance,
    and intensity formats are usually the most problematic.  Some sized
    formats can also be problematic.  This patch provides fall-back
    formats for those that are not natively supported.
    
    At some point it would be interesting to try providing
    device-independent conversions using EXT_texture_swizzle.  The drivers
    that support EXT_texture_swizzle could, for example, see
    GL_LUMINANCE16_SNORM as MESA_FORMAT_SIGNED_R16 with a { r, r, r, 1 }
    swizzle.  Care would need to be taken to prevent issues with using
    those textures for FBO rendering.
    
    This is the rest of the fix for glean's pixelFormats test on i965.
    
    Reviewed-by: Marek Olšák <maraeo@gmail.com>
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

commit ad3fbac00bb4430aa26f4dbd3a795715b0fc7fef
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Sat Apr 2 18:49:13 2011 -0700

    i965: Add the missing supportable EXT_texture_snorm formats
    
    This class of hardware can natively sample all of the snorm surface
    formats that DX10 requires, but it can't do some of the legacy GL
    formats.  In particular, all of the alpha, luminance, and intensity
    formats are unsupported.
    
    This partially fixes the breakage in glean's pixelFormats test since
    GL_EXT_texture_snorm support was added to Mesa.
    
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Comment 2 fangxun 2011-04-07 19:50:40 UTC
Verified with mesa master commit 0c501bacef3738b55986292abca149dcfe76d72d.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.