Some bugs in the documentation build: - xsltproc isn't detected correctly - dbus.devhelp should be installed to $(htmldir), not $(apidir), since it is an index for the spec and tutorial as well as the API docs (and the relative paths assume that location) - various of the other docs could be installed automatically The patches I'm about to attach will install: - the xmlto-generated docs (FAQ, spec, test plan, tutorial) - *.1.html (HTMLized man pages) - diagram.* - system-activation.txt They will not install the following things which are in dbus-docs.tar.gz: - DTDs: I'm not sure how useful these are as documentation - Docbook source for the xmlto-generated docs: the HTML seems more useful for everyone except D-Bus developers - dcop-howto.txt: we're not DCOP :-) and this seems to only be there for reference/inspiration - introspect.xsl: not actually documentation, although it could be used in our build system one day - ../README, ../NEWS, ../ChangeLog: if Debian is anything to go by, distributions tend to have their own mechanisms to copy these - ../AUTHORS: not amazingly useful since it's auto-generated from git, so it lists everyone who has ever touched D-Bus - ../COPYING: distributions tend to have their own way to document copyright/licensing status - ../HACKING: anyone who'll be reading this wants the source anyway
Created attachment 45516 [details] [review] configure.ac: fix check for xsltproc Pre-setting XSLTPROC interferes with AC_CHECK_PROGS letting the user override choice of program via the environment.
Created attachment 45517 [details] [review] Install dbus.devhelp to $(htmldir), not $(apidir), and remove it in clean It needs to be in $(htmldir) so that its relative paths will work.
Created attachment 45518 [details] [review] Install xmlto output to $(htmldir) automatically Also rename HTML_FILES to XMLTO_OUTPUT, as a more self-describing name: we have other HTML files which are not the output from xmlto.
Created attachment 45519 [details] [review] Install diagram.*, system-activation.txt to the $(docdir)
Created attachment 45520 [details] [review] Install man2html output to $(htmldir)
Created attachment 45521 [details] [review] Uninstall the installed docs
Review of attachment 45516 [details] [review]: ++
Review of attachment 45517 [details] [review]: Yup.
Review of attachment 45518 [details] [review]: OKay!
Review of attachment 45519 [details] [review]: Yup.
Review of attachment 45520 [details] [review]: ++
Review of attachment 45521 [details] [review]: Ship it.
Thanks, fixed in git for 1.4.12, 1.5.6.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.