Bug 36420 - Disable automagicness on Farsight and Glib
Summary: Disable automagicness on Farsight and Glib
Status: RESOLVED NOTABUG
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-qt (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-20 05:37 UTC by Tomáš Chvátal
Modified: 2011-06-07 01:11 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
automagicness.patch (6.75 KB, patch)
2011-04-20 05:37 UTC, Tomáš Chvátal
Details | Splinter Review

Description Tomáš Chvátal 2011-04-20 05:37:23 UTC
Created attachment 45859 [details] [review]
automagicness.patch

Farsight and Glib are both detected during configure phase and does not allow any specification whether we want to build with or without them.

Please see attached patch that solves the issue for us in Gentoo.
Comment 1 Olli Salli 2011-04-23 11:56:43 UTC
Why would you want to disable essentially the entire unit test suite? That's what disabling tp-glib use does, with no effect to the actual library binary.
Comment 2 Olli Salli 2011-05-25 01:44:01 UTC
OK, I'm resolving this as not a bug.

I'll reiterate: the farsight and glib bits don't have *any* effect on the main library binary or headers. They don't cause any "bloat" increase in it, which I guess is your main concern.

tp-glib, and qt support for the glib mainloop are only used for building and running the unit tests. Running them if you have the required bits installed doesn't hurt any - rather only helps catch regressions. Then again if your ebuild isn't running make check, they have no effect whatsoever.

Farsight causes a single pkgconfig file, a single header (Farsight/channel.h) and a tiny library (telepathy-qt4-farsight) to be built and installed, which combined takes around 1sec out of the several minutes for the entire library build. Your ebuild can use the farsight use flag (if you have something like that) to avoid installing them from the build sandbox instead, if you're concerned with filesystem usage.
Comment 3 David Heidelberg (okias) 2011-06-06 11:56:37 UTC
That issue is still valid for 0.7.0, please at least have some look on it.

Thank you
Comment 4 Olli Salli 2011-06-07 01:11:35 UTC
I know it's there, as we haven't changed a thing. However, please respond to my queries about what kind of drawbacks does automatically picking up them cause, so that we can look into ways to mitigate them.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.