Created attachment 46464 [details] [review] 0001-cairo.h-Remove-a-trailing-comma-from-an-enum.patch This small patch fixes some warnings, for instance, with cairomm.
Please?
(In reply to comment #1) > Please? Pushed. Thank you! commit d0615633dc1529af44740f8326ca1886a8b3bf5c Author: Murray Cumming <murrayc@murrayc.com> Date: Mon May 9 09:45:06 2011 +0200 cairo: Remove trailing comma from cairo_format_t Fixes warnings when building with C++. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=36989
Out of curiosity, is it your C++ compiler that dislikes trailing commas? Because in harfbuzz I'm using C++ and have assumed that trailing commas are harmless. I don't get a warning so far.
(In reply to comment #3) > Out of curiosity, is it your C++ compiler that dislikes trailing commas? > Because in harfbuzz I'm using C++ and have assumed that trailing commas are > harmless. I don't get a warning so far. Yes it's g++. We use a higher than normal level of warnings and we enable them as errors during distcheck so we never have them for long.
What's the set of flags you use? I personally have an extensive set of compiler warning flags that I use, but cannot find one for trailing comma. Thanks.
-pedantic -Wall -Wextra(In reply to comment #5) > What's the set of flags you use? -pedantic -Wall -Wextra I don't know which one turns on this warning. We find them generally useful, though this one is just generally annoying. But I've never given it much thought - I just fix it when I see it.
Ah, -pedantic. Thanks.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.