37172 – Allow file request with NULL filename

Bug 37172 - Allow file request with NULL filename

Summary: Allow file request with NULL filename

Status:	RESOLVED FIXED

Alias:	None

Product:	cups-pk-helper
Classification:	Unclassified
Component:	General (show other bugs)
Version:	unspecified
Hardware:	Other All

Importance:	medium normal
Assignee:	Vincent Untz
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-05-13 04:37 UTC by Marek Kasik
Modified:	2011-07-05 05:11 UTC (History)
CC List:	0 users

See Also:
i915 platform:
i915 features:

Attachments
allow adding of printers without PPD (1.07 KB, patch) 2011-05-23 01:18 UTC, Marek Kasik	Details \| Splinter Review
View All

Description Marek Kasik 2011-05-13 04:37:32 UTC

Allowing NULL filename in cupsDoFileRequest() enables cups-pk-helper to add raw printers. These don't have PPDs. CUPS is able to handle the situation when we do cupsDoFileRequest() with filename = NULL but it doesn't do the same when we pass there an empty string ("").

The patch detects that an empty string is passed as filename and uses NULL instead of it.

Marek


Additional info:
This enables us to rename raw printers in gnome-control-center's Printers panel (see https://bugzilla.gnome.org/show_bug.cgi?id=649511).

Comment 1 Vincent Untz 2011-05-19 09:34:05 UTC

Missing patch? :-)

Comment 2 Marek Kasik 2011-05-23 01:18:55 UTC

Created attachment 47025 [details] [review]
allow adding of printers without PPD

Yes, you are right, there should be a patch :). Here it is.

Marek

Comment 3 Vincent Untz 2011-07-05 04:53:43 UTC

Thanks, committed! I've changed the indentation :-)

Comment 4 Vincent Untz 2011-07-05 05:11:56 UTC

FWIW, I released 0.1.3 :-)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.