Bug 37176 - Crash in log_store_pidgin_get_dir
Summary: Crash in log_store_pidgin_get_dir
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: logger (show other bugs)
Version: unspecified
Hardware: Other All
: medium major
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: Pending unit test
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-13 05:38 UTC by Guillaume Desmottes
Modified: 2011-10-31 10:56 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
log_store_pidgin_get_dir: get the length of orig_id instead of id (#37176) (951 bytes, patch)
2011-05-13 05:39 UTC, Guillaume Desmottes 		Details | Splinter Review
View All

Description Guillaume Desmottes 2011-05-13 05:38:43 UTC 
I experienced this crash when opening empathy's log viewer.


(gdb) bt
#0  __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:32
#1  0x00007ffff0029f38 in log_store_pidgin_get_dir (self=0xa26cc0, account=0x8c49a0, target=0xf3bc00) at log-store-pidgin.c:345
#2  0x00007ffff002a3c2 in log_store_pidgin_get_dates (self=0xa26cc0, account=0x8c49a0, target=0xf3bc00, type_mask=65535)
    at log-store-pidgin.c:453
#3  0x00007ffff002123f in _tpl_log_store_get_dates (self=0xa26cc0, account=0x8c49a0, target=0xf3bc00, type_mask=65535) at log-store.c:190
#4  0x00007ffff001e3a8 in _tpl_log_manager_get_dates (manager=0xa26d00, account=0x8c49a0, target=0xf3bc00, type_mask=65535)
    at log-manager.c:516
#5  0x00007ffff001f53b in _get_dates_async_thread (simple=0x10cb580, object=0xa26d00, cancellable=0x0) at log-manager.c:904
#6  0x00007ffff438f556 in run_in_thread (job=0x7fffe04f8220, c=0x0, _data=0x7fffe04f2c30) at gsimpleasyncresult.c:842
#7  0x00007ffff437c3f7 in io_job_thread (data=0x7fffe04f8220, user_data=0x0) at gioscheduler.c:180
#8  0x00007ffff2f82618 in g_thread_pool_thread_proxy (data=0x88d560) at gthreadpool.c:319
#9  0x00007ffff2f80f00 in g_thread_create_proxy (data=0xfdfad0) at gthread.c:1897
#10 0x00007ffff150ad8c in start_thread (arg=0x7fffd2ffd700) at pthread_create.c:304
#11 0x00007fffebfc604d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#12 0x0000000000000000 in ?? ()
(gdb) r
Comment 1 Guillaume Desmottes 2011-05-13 05:39:57 UTC 
Created attachment 46681 [details] [review]
log_store_pidgin_get_dir: get the length of orig_id instead of id (#37176)
Comment 2 Nicolas Dufresne 2011-05-13 06:58:20 UTC 
(In reply to comment #1)
> Created an attachment (id=46681) [details]
> log_store_pidgin_get_dir: get the length of orig_id instead of id (#37176)

Patch looks good, but we need unit test, so we don't break this code again.
Comment 3 Guillaume Desmottes 2011-05-13 07:18:06 UTC 
Merged to master; will be in 0.2.10.

I keep the bug open as there is no unit test yet.
Comment 4 Nicolas Dufresne 2011-10-31 10:56:48 UTC 
Oh well, it's useless to keep that open forever.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.