Bug 37272 - Task: Add olpc-phonetic option to am symbol table
Summary: Task: Add olpc-phonetic option to am symbol table
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-05-16 14:31 UTC by Walter Bender
Modified: 2011-05-17 13:52 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
patch to add oloc-phonetic option to am (739 bytes, application/octet-stream)
2011-05-16 14:49 UTC, Walter Bender 		Details
add description for am olpc-phonetic variant to rules/base.xml.in (901 bytes, application/octet-stream)
2011-05-16 18:07 UTC, Walter Bender 		Details
patch for adding variant to base.extras.xml.in (1.16 KB, patch)
2011-05-17 06:13 UTC, Walter Bender 		Details | Splinter Review
adding olpc-phonetic to base.extra.xml.in (1.17 KB, patch)
2011-05-17 13:44 UTC, Walter Bender 		Details | Splinter Review
Show Obsolete (2) View All

Description Walter Bender 2011-05-16 14:31:35 UTC 
As per the attached patch, please add the olpc-phonetic option to the am symbol table. This option will be used by the new OLPC XOs being produced for a major deployment in Armenia.

FYI, there is an rpm built with this patch applied at https://dev.laptop.org/~martin/public_rpms/f11/?C=M;O=D
Comment 1 Sergey V. Udaltsov 2011-05-16 14:46:08 UTC 
Sorry, where is the patch?
Comment 2 Walter Bender 2011-05-16 14:49:38 UTC 
Created attachment 46785 [details]
patch to add oloc-phonetic option to am

Not sure why this didn't attach with the ticket the first time...
Comment 3 Sergey V. Udaltsov 2011-05-16 15:04:54 UTC 
Committed. Why do you not propose the patch for base.xml.in (or base.extras.xml.in). Do you not want that variant to be visible in GUIs?
Comment 4 Walter Bender 2011-05-16 15:11:33 UTC 
Ignorance on my part. I'll look into it and get back to you ASAP. Thanks.
Comment 5 Walter Bender 2011-05-16 18:07:18 UTC 
Created attachment 46787 [details]
add description for am olpc-phonetic variant to rules/base.xml.in

As per suggestion, added a description to the rules/base.xml.in file for the new symbols option for am.
Comment 6 Sergey V. Udaltsov 2011-05-17 00:06:37 UTC 
would not it be more correct to put it into base.extras.xml.in? According to the rules http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules
Comment 7 Walter Bender 2011-05-17 04:15:24 UTC 
I was following the lead of whomever added the OLPC options to for the Afghan keyboards. I'll prepare a patch for extras and perhaps a second patch to move the OLPC afghani options there as well.
Comment 8 Walter Bender 2011-05-17 06:13:14 UTC 
Created attachment 46815 [details] [review]
patch for adding variant to base.extras.xml.in

As per suggestion, adding variant to extras. Please ignore 46787
Comment 9 Sergey V. Udaltsov 2011-05-17 12:55:20 UTC 
your patch adds phonetic-alt to extras. what about olpc-phonetic?
Comment 10 Walter Bender 2011-05-17 13:44:37 UTC 
Created attachment 46839 [details] [review]
adding olpc-phonetic to base.extra.xml.in

Sorry. Not enough sleep lately. Hopefully I got it correct this time.
Comment 11 Sergey V. Udaltsov 2011-05-17 13:52:05 UTC 
Right, replaced that...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.