Bug 37343 - systemctl's bash completion does not list all "restartable" services
Summary: systemctl's bash completion does not list all "restartable" services
Status: RESOLVED FIXED
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium trivial
Assignee: Lennart Poettering
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-18 23:23 UTC by Steven Danna
Modified: 2013-04-03 18:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
One-line change to systemctl-bash-completion.sh (667 bytes, patch)
2011-05-18 23:23 UTC, Steven Danna 		Details | Splinter Review
View All

Description Steven Danna 2011-05-18 23:23:58 UTC 
Created attachment 46886 [details] [review]
One-line change to systemctl-bash-completion.sh

The current bash completion script will only list inactive units when given a "STARTABLE_UNITS" verb.  This is fine for the verb "start" but not for "restart" (which is also a "STARTABLE_UNITS" verb) since one presumably wants to be able to restart active units as well.

Attached is a diff with a one-line change that corrects the behavior.
Comment 1 Zbigniew Jedrzejewski-Szmek 2013-04-03 18:49:38 UTC 
Appears to have been fixed at some point. /usr/share/bash-completion/completions/systemctl now uses __get_inactive_units for start and __get_all_units for restart.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.