Bug 37396 - spice-gtk compile error on RHEL
Summary: spice-gtk compile error on RHEL
Status: RESOLVED FIXED
Alias: None
Product: Spice
Classification: Unclassified
Component: spice-gtk (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: Spice Bug List
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 00:33 UTC by David Jaša
Modified: 2011-05-24 08:41 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
full ./configure and make output (12.95 KB, text/plain)
2011-05-20 00:33 UTC, David Jaša
Details
don't use glib 2.26 api (3.26 KB, patch)
2011-05-20 04:23 UTC, Marc-Andre Lureau
Details | Splinter Review
don't use glib 2.26 api (3.27 KB, patch)
2011-05-20 04:24 UTC, Marc-Andre Lureau
Details | Splinter Review

Description David Jaša 2011-05-20 00:33:17 UTC
Created attachment 46934 [details]
full ./configure and make output

When compiling spice-gtk from git on nightly RHEL (with missing dependencies backported from Fedora and spice-protocol also from git), I'm getting this error:

make[5]: Entering directory `/home/david/src/spice-gtk/gtk/controller'
  CC     menu.lo
  CC     controller.lo
controller.c: In function ‘spice_controller_listen_co’:
controller.c:933: warning: assignment discards qualifiers from pointer target type
controller.c:955: warning: implicit declaration of function ‘g_unix_socket_address_new_with_type’
controller.c:955: error: ‘G_UNIX_SOCKET_ADDRESS_PATH’ undeclared (first use in this function)
controller.c:955: error: (Each undeclared identifier is reported only once
controller.c:955: error: for each function it appears in.)
make[5]: *** [controller.lo] Error 1

Versions:
gcc-4.4.5-6.el6.x86_64
pygtk2-devel-2.16.0-3.el6.x86_64
intltool-0.41.0-1.1.el6.noarch
celt051-devel-0.5.1.3-0.el6.x86_64
gtk2-devel-2.18.9-6.el6.x86_64
openssl-devel-1.0.0-10.el6.x86_64
package pulseaudio-devel not installed
pixman-devel-0.18.4-1.el6_0.1.x86_64
python-2.6.6-20.el6.x86_64
spice-protocol from git
Comment 1 Christophe Fergeau 2011-05-20 01:35:37 UTC
The GSocket API was added in glib 2.26, and RHEL6 only have 2.22.5. I'm not sure what is the right course of action here. configure.ac should check for glib 2.26, that's for sure, but I don't know if we should disable the controller stuff when glib's too old or do something else.
Comment 2 Christophe Fergeau 2011-05-20 02:41:26 UTC
(In reply to comment #1)
> The GSocket API was added in glib 2.26, and RHEL6 only have 2.22.5. 

Small correction, GSocket is glib 2.22, but g_unix_socket_address_new_with_type was added in 2.26
Comment 3 Marc-Andre Lureau 2011-05-20 04:23:21 UTC
Created attachment 46945 [details] [review]
don't use glib 2.26 api

that could be build workaround for 0.6 build with glib 2.22
Comment 4 Marc-Andre Lureau 2011-05-20 04:24:54 UTC
Created attachment 46946 [details] [review]
don't use glib 2.26 api

the previous patch was reversed


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.