Bug 37611 - Messages ordered by "timestamp" not "original-timestamp" (where appropriate)
Summary: Messages ordered by "timestamp" not "original-timestamp" (where appropriate)
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: logger (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-25 19:54 UTC by Danielle Madeley
Modified: 2011-05-26 18:47 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Danielle Madeley 2011-05-25 19:54:29 UTC
From https://bugs.freedesktop.org/show_bug.cgi?id=37413#c10

Sent 9 messages, the numbers 1-9 and then edited "5". When requesting the last 5 messages in Empathy I get "6", "7", "8", "9", "5E" with timestamps (either timestamp or original-timestamp as appropriate):

"6" 12:28:43
"7" 12:28:45
"8" 12:28:47
"9" 12:28:53
"5E" 12:28:33 -- which was edited at 12:33:04
Comment 1 Nicolas Dufresne 2011-05-26 18:47:32 UTC
Is fixed in 0.2.10. The logger needed to TplEvent to be sortable. Changing this was changing semantic, which would mean not keeping backward compatibility. It would also have made the logger code messy. The time the message was edited can be retrieved using tpl_text_event_get_edit_timestamp().

We also took this opportunity to optimize and fix the message merging. get_filtered_events() should be faster now.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.